Repository navigation
Conversation
role="button" to link in button group.role="button" and button functionality to link in button group.
1 of 2 tasks
mejiaj
marked this pull request as ready for review
November 13, 2020 17:34
sarnikbixal
approved these changes
Nov 17, 2020
1 of 2 tasks
Contributor
Author
Todo
Expected resultsLinks with the class |
4 tasks done
Contributor
|
Done and done!
|
role="button" and button functionality to link in button group.
Contributor
Author
|
Closing this PR in favor of #4385. |
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
Button group →
Description
Users should be able to add
role="button"to links (using best judgement) and expect it to trigger a click on spacebar, like native buttons do.Part of #3690.
role="button"to the link in button group.role="button"now behave like buttons (spacebarandenteractivate).Additional Notes
MDN on button role
Sources:
Slack thread →
Original issue →
MDN on Button role →
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.