Visitar URL original
USWDS - Forms: Add required field label. by mejiaj · Pull Request #3828 · uswds/uswds · GitHub
Skip to content

USWDS - Forms: Add required field label. - #3828

Merged
thisisdano merged 12 commits into
developfrom
jm-required-fields
Feb 11, 2021
Merged

thisisdano merged 12 commits into
developfrom
jm-required-fields

Conversation

@mejiaj

@mejiaj mejiaj commented Nov 12, 2020 •

Copy link
Copy Markdown
Contributor

Description

Part of #3691.

Additional information

Labels and adds description for required field inputs on address and name form templates.

Preview links

Name form →

Address form →

Related PRs

Guidance update
Update Address Form template


Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj
mejiaj requested a review from allie-shaw November 12, 2020 18:05
@allie-shaw

Copy link
Copy Markdown

Looks good to me.

@allie-shaw allie-shaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mejiaj
mejiaj requested a review from thisisdano November 12, 2020 21:25
@jAigret-Bix jAigret-Bix linked an issue Nov 23, 2020 that may be closed by this pull request
5 of 6 tasks

@thisisdano thisisdano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated a bit of the text and the styling, but this is good to go

@thisisdano
thisisdano merged commit 56561f4 into develop Feb 11, 2021
@thisisdano
thisisdano deleted the jm-required-fields branch February 11, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Form controls: labeling required fields

3 participants