Visitar URL original
Use theme reverse colors across reversed components by thisisdano · Pull Request #4059 · uswds/uswds · GitHub
Skip to content

Use theme reverse colors across reversed components #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejiaj merged 4 commits into from
Mar 3, 2021
Merged

Use theme reverse colors across reversed components #4059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00ad6c2
Use theme reverse colors across reversed components
thisisdano Mar 1, 2021
6369084
Update .snyk
thisisdano Mar 1, 2021
8ce8496
Merge branch 'develop' into dw-use-proper-color-tokens
thisisdano Mar 3, 2021
6511249
Use them var for reverse text in usa-dark-background
thisisdano Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/stylesheets/components/_section.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,21 @@

.usa-section--dark {
background-color: color("primary-darker");
color: color("white");
color: color($theme-text-reverse-color);

h1,
h2,
h3,
h4,
h5,
h6 {
// TODO: This should use a theme-able color,
// and should probably default to white
color: color("accent-cool");
}

p {
color: color("white");
color: color($theme-text-reverse-color);
}

a {
Expand Down
6 changes: 3 additions & 3 deletions src/stylesheets/elements/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,9 @@ $button-stroke: inset 0 0 0 units($theme-button-stroke-width);
}

&.usa-button--inverse {
$button-inverse-color: "base-lighter";
$button-inverse-hover-color: "base-lightest";
$button-inverse-active-color: "white";
$button-inverse-color: $theme-link-reverse-color;
$button-inverse-hover-color: $theme-link-reverse-hover-color;
$button-inverse-active-color: $theme-link-reverse-active-color;

box-shadow: $button-stroke color("base-lighter");
color: color($button-inverse-color);
Expand Down
8 changes: 4 additions & 4 deletions src/stylesheets/elements/typography/_content.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,18 +41,18 @@

p,
span {
color: color("white");
color: color($theme-text-reverse-color);
}
Comment thread
mejiaj marked this conversation as resolved.
Resolved

a {
color: color("base-lighter");
color: color($theme-link-reverse-color);

&:visited {
color: color("base-lighter");
color: color($theme-link-reverse-color);
}

&:hover {
color: color("white");
color: color($theme-link-reverse-hover-color);
}
}
}
Expand Down