Visitar URL original
Accessibility updates [uswds-site 1227] by thisisdano · Pull Request #4197 · uswds/uswds · GitHub
Skip to content

Accessibility updates [uswds-site 1227] #4197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 28 commits into from
May 17, 2021
Merged

Accessibility updates [uswds-site 1227] #4197

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
119864b
Use unique IDs in breadcrumb
thisisdano Apr 19, 2021
5b2f3eb
Use unique aria-labels for banners
thisisdano Apr 19, 2021
8ff46c2
Use unique aria labels for footer
thisisdano Apr 19, 2021
e712dc2
Add unique labels for identifier
thisisdano Apr 19, 2021
06a245e
Use h3 for list headings
thisisdano Apr 19, 2021
cbe75ac
Use underscore hack to provide unique labels
thisisdano Apr 20, 2021
09a3674
Use underscore hack for footer labels
thisisdano Apr 20, 2021
3a23b3a
Use unique aria labels
thisisdano May 11, 2021
6ace906
Use proper heading levels
thisisdano May 12, 2021
cca6bc0
Use unique aria labels
thisisdano May 12, 2021
b10c786
Remove complementary role
thisisdano May 12, 2021
b907286
Allow keyboard focus on scrollable tables
thisisdano May 12, 2021
ef048c0
Use void links
thisisdano May 13, 2021
d952987
Fix download links
thisisdano May 13, 2021
c1068ca
Use void in button-group links
thisisdano May 13, 2021
d1d96f9
Use commas for better voicing
thisisdano May 17, 2021
07a1ae8
Use trailing comma hack for breadcrumbs
thisisdano May 17, 2021
f0b6d31
Use trailing comma hack for sidenav
thisisdano May 17, 2021
4a22724
Use trailing comma hack for sidenav
thisisdano May 17, 2021
fabbae6
Update snyk and reinstall deps
thisisdano May 17, 2021
3e6a2f9
Merge branch 'develop' into dw-site-pa11y
thisisdano May 17, 2021
3f96929
Update package-lock.json
thisisdano May 17, 2021
d16b19f
Replace placeholder hash links with javascript:void(0);
thisisdano May 17, 2021
8e3831b
Give summary box an ARIA region labeled with the component hed ID
thisisdano May 17, 2021
8eb9161
Remove wrap class from breadcrumb default
thisisdano May 17, 2021
52ca395
Add ARIA label to default sidenav
thisisdano May 17, 2021
11dca56
Merge branch 'dw-site-pa11y' of https://github.com/uswds/uswds into d…
thisisdano May 17, 2021
46615f3
Default to js:void for sidenav links
thisisdano May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use void links
  • Loading branch information
@thisisdano
thisisdano committed May 13, 2021
commit ef048c081e0e130bbb5d693e99205139dd7ca5d4
12 changes: 6 additions & 6 deletions src/components/summary-box/summary-box.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@
<div class="usa-summary-box__text">
<ul class="usa-list">
<li>If you are under a winter storm warning,
<a class="usa-summary-box__link" href="#usa-anchor-find-shelter">find shelter</a>
<a class="usa-summary-box__link" href="javascript:void(0);">find shelter</a>

@thisisdano thisisdano May 17, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use fake anchor links

right away.</li>
<li>Sign up for
<a class="usa-summary-box__link" href="#usa-anchor-warning-system">your community’s warning system</a>.</li>
<a class="usa-summary-box__link" href="javascript:void(0);">your community’s warning system</a>.</li>
<li>Learn the signs of, and basic treatments for,
<a class="usa-summary-box__link" href="#usa-anchor-frostbite">frostbite</a>
<a class="usa-summary-box__link" href="javascript:void(0);">frostbite</a>
and
<a class="usa-summary-box__link" href="#usa-anchor-hypothermia">hypothermia</a>.</li>
<a class="usa-summary-box__link" href="javascript:void(0);">hypothermia</a>.</li>
<li>Gather emergency supplies for your
<a class="usa-summary-box__link" href="#usa-anchor-home">home</a>
<a class="usa-summary-box__link" href="javascript:void(0);">home</a>
and your
<a class="usa-summary-box__link" href="#usa-anchor-car">car</a>.</li>
<a class="usa-summary-box__link" href="javascript:void(0);">car</a>.</li>
</ul>
</div>
</div>
Expand Down