Visitar URL original
USWDS - Checkbox + Radio: create background color variable. by mejiaj · Pull Request #4199 · uswds/uswds · GitHub
Skip to content

USWDS - Checkbox + Radio: create background color variable. #4199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 18 commits into from
Jun 7, 2021
Merged

USWDS - Checkbox + Radio: create background color variable. #4199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ac03d17
Checkbox: add new background variable to tile.
May 17, 2021
5793e89
Checkbox: use `set-text-and-bg()` to set color on tiles.
May 17, 2021
037e93a
Use custom colors for radio inputs
thisisdano May 26, 2021
28f9c8c
Update disabled:checked styles
thisisdano May 26, 2021
6f419bf
Sync settings
thisisdano May 26, 2021
0cbf97e
Merge branch 'develop' into jm-tile-add-bg
thisisdano May 26, 2021
adf7f11
Revert to white bg
thisisdano May 26, 2021
bf4e63d
Add mixin for quickly setting custom color
thisisdano May 27, 2021
07be940
Fix checkbox preview
thisisdano May 27, 2021
7d84ed7
Add custom color test
thisisdano May 27, 2021
5b27e13
Remove IE9 code
thisisdano Jun 2, 2021
5c32703
Simplify and organize code
thisisdano Jun 2, 2021
d108bfc
Allow checkbox-and-radio-colors() to set custom checked color
thisisdano Jun 2, 2021
999a4d6
Use proper IDs in checkbox test
thisisdano Jun 2, 2021
ee525ae
Include test code [for now]
thisisdano Jun 2, 2021
3992ed9
Use "selected" instead of "checked"
thisisdano Jun 2, 2021
8c33817
Set background color for elements based on setting
thisisdano Jun 3, 2021
81ba70f
Comment out test code
thisisdano Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Checkbox: add new background variable to tile.
  • Loading branch information
James Mejia
James Mejia committed May 17, 2021
commit ac03d17c9c126f68218ca402244b7527d8e0d806
1 change: 1 addition & 0 deletions src/stylesheets/settings/_settings-components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ $theme-input-max-width: "mobile-lg" !default;
$theme-input-select-border-width: 2px !default;
$theme-input-select-size: 2.5 !default;
$theme-input-state-border-width: 0.5 !default;
$theme-input-tile-background-color: "white" !default;
$theme-input-tile-background-color-selected: "primary-lighter" !default;

@thisisdano thisisdano Jun 2, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The system now sets this automatically based on the background color. The tile background color is a more transparent version of the calculated text/border color

$theme-input-tile-border-radius: "md" !default;
$theme-input-tile-border-width: 2px !default;
Expand Down
1 change: 1 addition & 0 deletions src/stylesheets/theme/_uswds-theme-components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ $theme-input-max-width: "mobile-lg";
$theme-input-select-border-width: 2px;
$theme-input-select-size: 2.5;
$theme-input-state-border-width: 0.5;
$theme-input-tile-background-color: "white";
$theme-input-tile-background-color-selected: "primary-lighter";
$theme-input-tile-border-radius: "md";
$theme-input-tile-border-width: 2px;
Expand Down