Repository navigation
USWDS - Search: Use inline image for Search icon - #4274
Merged
Merged
Conversation
Contributor
|
LGTM. Holding to release with footer at the next minor (2.13) |
thisisdano
approved these changes
Sep 20, 2021
thisisdano
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
Description
Fixes #4272. The search icon has been converted from a background to an inline image. This is to ensure there's a text alternative should images fail to load.
⚠ Requires a markup change to Search component and/or header.
New markup
The new addition is the inline image for the search icon.
Default & Big search
Small search
Additional information
Related to issue #4207.
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.