Visitar URL original
USWDS - File Input: Creates unique ID per upload. Fixes #4144 by mahoneycm · Pull Request #4313 · uswds/uswds · GitHub
Skip to content

USWDS - File Input: Creates unique ID per upload. Fixes #4144 #4313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 5 commits into from
Oct 25, 2021
Merged

USWDS - File Input: Creates unique ID per upload. Fixes #4144 #4313

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
97794d6
Fixes image preview for multiple submissions of same document
Sep 1, 2021
2a1775f
Fixed indenting
Sep 2, 2021
5357458
Adds Unique ID function to fix multiple upload preview issues
Sep 3, 2021
82698ee
Cleaned up comments and removed console log
Sep 7, 2021
fa8939b
Merge branch 'develop' into cm-file-upload-test
Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/js/components/file-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ const replaceName = (s) => {
*/
const makeSafeForID = (name) => name.replace(/[^a-z0-9]/g, replaceName);

// Takes a generated safe ID and creates a unique ID.
const createUniqueID = (name) => `${name}-${Math.floor(Date.now().toString() / 1000)}`;

/**
* Builds full file input component
* @param {HTMLElement} fileInputEl - original file input on page
Expand Down Expand Up @@ -222,7 +225,7 @@ const handleChange = (e, fileInputEl, instructions, dropTarget) => {

// Starts with a loading image while preview is created
reader.onloadstart = function createLoadingImage() {
const imageId = makeSafeForID(fileName);
const imageId = createUniqueID(makeSafeForID(fileName));

instructions.insertAdjacentHTML(
"afterend",
Expand All @@ -234,7 +237,7 @@ const handleChange = (e, fileInputEl, instructions, dropTarget) => {

// Not all files will be able to generate previews. In case this happens, we provide several types "generic previews" based on the file extension.
reader.onloadend = function createFilePreview() {
const imageId = makeSafeForID(fileName);
const imageId = createUniqueID(makeSafeForID(fileName));
const previewImage = document.getElementById(imageId);
if (fileName.indexOf(".pdf") > 0) {
previewImage.setAttribute(
Expand Down