Visitar URL original
USWDS - Accessibility: Added button functionality to usa-button links by mahoneycm · Pull Request #4385 · uswds/uswds · GitHub
Skip to content

USWDS - Accessibility: Added button functionality to usa-button links #4385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 18 commits into from
May 10, 2023
Merged

USWDS - Accessibility: Added button functionality to usa-button links #4385

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
cd47f33
Add `role="button"` to link in button group.
mejiaj Oct 5, 2020
84d0d75
Add role button JS to trigger on space.
mejiaj Nov 13, 2020
65d7641
Add space key in keymap function and remove test code.
mejiaj Nov 13, 2020
6e4df71
Adds button functionality to links with usa-button class
Nov 2, 2021
6c406a4
Updated dependenies
Nov 4, 2021
4eef3bb
Removed role=button and replaced href single quotes with double quotes
Nov 17, 2021
af3c555
Updated to the latest
Dec 2, 2021
be9af77
Removed mention of USA button from buttons.js
Dec 3, 2021
f7c6b7b
Merge branch 'develop' of https://github.com/uswds/uswds into cm-butt…
Dec 9, 2021
d21c9b5
Fixed button.js variable names
Dec 9, 2021
a84aa4b
Merge branch 'develop' of github.com:uswds/uswds into cm-button-group…
mahoneycm Mar 14, 2023
d556ab4
Move button js to from src to button package
mahoneycm Mar 14, 2023
1819474
Remove depreciated src/js/components
mahoneycm Mar 14, 2023
22ee254
Button Group: Add role to usa-button anchor
mahoneycm Mar 14, 2023
a9e1048
Remove role=button based on Dan's comment in #3690
mahoneycm Mar 14, 2023
3b5316b
Replace buttons in usa-card with usa-button anchors
mahoneycm Mar 14, 2023
f0fc39e
Add empty line after require
mahoneycm Mar 14, 2023
124fe94
Run prettier js
mahoneycm Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed role=button and replaced href single quotes with double quotes
  • Loading branch information
Charlie Mahoney
Charlie Mahoney committed Nov 17, 2021
commit 4eef3bbefa43cb4ee83f7da56dbda100d7bacf0b
2 changes: 1 addition & 1 deletion src/components/11-button-groups/button-groups.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<h6>Default</h6>
<ul class="usa-button-group">
<li class="usa-button-group__item">
<a href="#" role="button" class="usa-button usa-button--outline">Back</a>
<a href="#" class="usa-button usa-button--outline">Back</a>
</li>
<li class="usa-button-group__item">
<button class="usa-button">Continue</button>
Expand Down
2 changes: 1 addition & 1 deletion src/components/card/_card--basic.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
</div>
<div class="usa-card__footer">
{%- block card_footer %}
<a href='#' class="usa-button">Visit Florida Keys</a>
<a href="#" class="usa-button">Visit Florida Keys</a>
{% endblock -%}
</div>
</div>
14 changes: 7 additions & 7 deletions src/components/card/card--compare.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Facilis earum tenetur quo cupiditate, eaque qui officia recusandae. Excepturi nobis dolores molestias! Quas quisquam a officia eos.</p>
</div>
<div class="usa-card__footer">
<a href='#' class="usa-button">Visit Florida Keys</a>
<a href="#" class="usa-button">Visit Florida Keys</a>
</div>
</div>
</li>
Expand All @@ -27,7 +27,7 @@
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Facilis earum tenetur quo cupiditate, eaque qui officia recusandae. Excepturi nobis dolores molestias! Quas quisquam a officia eos.</p>
</div>
<div class="usa-card__footer">
<a href='#' class="usa-button">Visit Florida Keys</a>
<a href="#" class="usa-button">Visit Florida Keys</a>
</div>
</div>
</li>
Expand All @@ -45,7 +45,7 @@
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Facilis earum tenetur quo cupiditate, eaque qui officia recusandae.</p>
</div>
<div class="usa-card__footer">
<a href='#' class="usa-button">Visit Florida Keys</a>
<a href="#" class="usa-button">Visit Florida Keys</a>
</div>
</div>
</li>
Expand All @@ -64,7 +64,7 @@
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Facilis earum tenetur quo cupiditate, eaque qui officia recusandae.</p>
</div>
<div class="usa-card__footer">
<a href='#' class="usa-button">Visit Florida Keys</a>
<a href="#" class="usa-button">Visit Florida Keys</a>
</div>
</div>
</li>
Expand All @@ -83,7 +83,7 @@
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Facilis earum tenetur quo cupiditate, eaque qui officia recusandae.</p>
</div>
<div class="usa-card__footer">
<a href='#' class="usa-button">Visit Florida Keys</a>
<a href="#" class="usa-button">Visit Florida Keys</a>
</div>
</div>
</li>
Expand All @@ -106,7 +106,7 @@
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit.</p>
</div>
<div class="usa-card__footer">
<a href='#' class="usa-button">Visit Florida Keys</a>
<a href="#" class="usa-button">Visit Florida Keys</a>
</div>
</div>
</li>
Expand All @@ -125,7 +125,7 @@
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit.</p>
</div>
<div class="usa-card__footer">
<a href='#' class="usa-button">Visit Florida Keys</a>
<a href="#" class="usa-button">Visit Florida Keys</a>
</div>
</div>
</li>
Expand Down