Visitar URL original
Update notifications by thisisdano · Pull Request #4426 · uswds/uswds · GitHub
Skip to content

Update notifications #4426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 3 commits into from
Dec 14, 2021
Merged

Update notifications #4426

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb93b68
Add 2.13.0 notifications and change order to oldest-first
thisisdano Dec 14, 2021
1b82a19
Clarify breaking changes and fix URL
thisisdano Dec 14, 2021
84d827e
Use parallel structure and fix syntax
thisisdano Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
183 changes: 98 additions & 85 deletions src/stylesheets/core/_notifications.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,79 +15,22 @@ $uswds-notifications:
+ "\A --------------------------------------------------------------------"
+ "\A \2709 USWDS Notifications"
+ "\A --------------------------------------------------------------------"
+ "\A 2.12.2:"
+ "\A - As a security precaution, we're now sanitizing text passed into "
+ "\A Tooltip. Tooltip no longer supports markup in its content."
+ "\A --------------------------------------------------------------------"
+ "\A 2.12.0:"
+ "\A - We deprecated three settings:"
+ "\A $theme-input-tile-background-color-selected"
+ "\A $theme-input-tile-border-color"
+ "\A $theme-input-tile-border-color-selected"
+ "\A Each of these is now calculated automatically"
+ "\A - We updated some settings defaults:"
+ "\A $theme-color-success-dark: green-cool-50v (was green-cool-50)"
+ "\A $theme-color-success-darker: green-cool-60v (was green-cool-80)"
+ "\A --------------------------------------------------------------------"
+ "\A 2.11.2:"
+ "\A - We deprecated the `$theme-site-max-width` variable. We're using"
+ "\A `$theme-grid-container-max-width` instead."
+ "\A - We replaced the `thumb_down_off_alt` icon with `thumb_down_alt`"
+ "\A in our default icon sprite."
+ "\A --------------------------------------------------------------------"
+ "\A 2.11.0:"
+ "\A - We updated some settings defaults:"
+ "\A $theme-alert-icon-size: 4 (was 5)"
+ "\A $theme-table-border-color: default (was 'ink')"
+ "\A $theme-table-header-text-color: default (was 'ink')"
+ "\A $theme-table-stripe-text-color: default (was 'ink')"
+ "\A $theme-table-text-color: default (was 'ink')"
+ "\A --------------------------------------------------------------------"
+ "\A 2.10.1:"
+ "\A - We updated the `$theme-breadcrumb-background-color` default"
+ "\A to `default` from `'white'`. "
+ "\A - We updated the `$theme-alert-icon-size` default to `5` from `4`."
+ "\A - [Footer] We updated `usa-footer__logo-heading` to use a `p`."
+ "\A instead of an `h3`. "
+ "\A --------------------------------------------------------------------"
+ "\A 2.10.0:"
+ "\A - We updated the Spanish language link to USAGov in the identifier. "
+ "\A The link should now read 'Visite USAGov en Español'. "
+ "\A - We improved the accessibility of SVG images in the banner. "
+ "\A See the full release notes for more information."
+ "\A --------------------------------------------------------------------"
+ "\A 2.9.0:"
+ "\A - We updated the formatting of `usa-legend`. If you use a visible "
+ "\A legend and wish to preserve the old styling, add a "
+ "\A `usa-legend--large` modifier to the element."
+ "\A --------------------------------------------------------------------"
+ "\A 2.8.0:"
+ "\A - We updated the text of the gov banner and its settings."
+ "\A Please see the full release notes for more information and update"
+ "\A your project's banner as soon as possible."
+ "\A --------------------------------------------------------------------"
+ "\A 2.7.1:"
+ "\A - We added `not dead` to our autoprefixer settings and now use a "
+ "\A `.browserslistrc` file for these options."
+ "\A --------------------------------------------------------------------"
+ "\A 2.7.0:"
+ "\A - We added new usa-button-group, usa-card, usa-character-count, and"
+ "\A usa-combo-box components."
+ "\A - We updated our guidance and code for numeric fields to use `text`"
+ "\A rather than `number` inputs with an `inputmode` of `numeric`."
+ "\A 2.0.2: We changed the names of some settings and mixins."

@thisisdano thisisdano Dec 14, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the order here to chronological from reverse-chronological so the most current notification is at the bottom. This means that the most current notification is visible in the terminal window when the compile completes and users don't have to scroll up to see the most current notification

+ "\A"
+ "\A - $theme-title-font-size \2192 $theme-display-font-size"
+ "\A - @include title \2192 @include display"
+ "\A - @include typeset-title \2192 @include typeset-display"
+ "\A --------------------------------------------------------------------"
+ "\A 2.6.0:"
+ "\A - We updated the markup of usa-search. Existing markup will still"
+ "\A work, but we recommend updating to the newest markup."
+ "\A - We updated some color token values and filled out the vivid color"
+ "\A families. This is not a breaking change, but be aware that there"
+ "\A may be some subtle changes."
+ "\A 2.2.0: We changed the names of some settings."
+ "\A"
+ "\A - $theme-navigation-width \2192 $theme-header-min-width"
+ "\A - $theme-megamenu-logo-text-width \2192 $theme-header-logo-text-width"
+ "\A --------------------------------------------------------------------"
+ "\A 2.5.1:"
+ "\A - CSSO's forceMediaMerge wasn't exporting media queries in the"
+ "\A expected order, so we're disabling it for more reliable CSS"
+ "\A output. We recommend that teams remove any media query sorting"
+ "\A added with forceMediaMerge."
+ "\A 2.4.0: If your component settings aren't working as expected, make"
+ "\A sure you're importing the components settings in your Sass entry"
+ "\A point (often styles.scss) with `@import 'uswds-theme-components'`."
+ "\A A bug in 2.0 omitted that import."
+ "\A - We added `$theme-show-notifications: true` to general settings"
+ "\A --------------------------------------------------------------------"
+ "\A 2.5.0:"
+ "\A - We updated to Dart Sass for compiling. Consider updating your own"
Expand All @@ -107,22 +50,92 @@ $uswds-notifications:
+ "\A - Now state tokens (like 'warning') can can accept non-token"
+ "\A colors, just as we introduced for theme colors in 2.4.0."
+ "\A --------------------------------------------------------------------"
+ "\A 2.4.0: If your component settings aren't working as expected, make"
+ "\A sure you're importing the components settings in your Sass entry"
+ "\A point (often styles.scss) with `@import 'uswds-theme-components'`."
+ "\A A bug in 2.0 omitted that import."
+ "\A - We added `$theme-show-notifications: true` to general settings"
+ "\A 2.5.1:"
+ "\A - CSSO's forceMediaMerge wasn't exporting media queries in the"
+ "\A expected order, so we're disabling it for more reliable CSS"
+ "\A output. We recommend that teams remove any media query sorting"
+ "\A added with forceMediaMerge."
+ "\A --------------------------------------------------------------------"
+ "\A 2.2.0: We changed the names of some settings."
+ "\A"
+ "\A - $theme-navigation-width \2192 $theme-header-min-width"
+ "\A - $theme-megamenu-logo-text-width \2192 $theme-header-logo-text-width"
+ "\A 2.6.0:"
+ "\A - We updated the markup of usa-search. Existing markup will still"
+ "\A work, but we recommend updating to the newest markup."
+ "\A - We updated some color token values and filled out the vivid color"
+ "\A families. This is not a breaking change, but be aware that there"
+ "\A may be some subtle changes."
+ "\A --------------------------------------------------------------------"
+ "\A 2.0.2: We changed the names of some settings and mixins."
+ "\A"
+ "\A - $theme-title-font-size \2192 $theme-display-font-size"
+ "\A - @include title \2192 @include display"
+ "\A - @include typeset-title \2192 @include typeset-display";
+ "\A 2.7.0:"
+ "\A - We added new usa-button-group, usa-card, usa-character-count, and"
+ "\A usa-combo-box components."
+ "\A - We updated our guidance and code for numeric fields to use `text`"
+ "\A rather than `number` inputs with an `inputmode` of `numeric`."
+ "\A --------------------------------------------------------------------"
+ "\A 2.7.1:"
+ "\A - We added `not dead` to our autoprefixer settings and now use a "
+ "\A `.browserslistrc` file for these options."
+ "\A --------------------------------------------------------------------"
+ "\A 2.8.0:"
+ "\A - We updated the text of the gov banner and its settings."
+ "\A Please see the full release notes for more information and update"
+ "\A your project's banner as soon as possible."
+ "\A --------------------------------------------------------------------"
+ "\A 2.9.0:"
+ "\A - We updated the formatting of `usa-legend`. If you use a visible "
+ "\A legend and wish to preserve the old styling, add a "
+ "\A `usa-legend--large` modifier to the element."
+ "\A --------------------------------------------------------------------"
+ "\A 2.10.0:"
+ "\A - We updated the Spanish language link to USAGov in the identifier. "
+ "\A The link should now read 'Visite USAGov en Español'. "
+ "\A - We improved the accessibility of SVG images in the banner. "
+ "\A See the full release notes for more information."
+ "\A --------------------------------------------------------------------"
+ "\A 2.10.1:"
+ "\A - We updated the `$theme-breadcrumb-background-color` default"
+ "\A to `default` from `'white'`. "
+ "\A - We updated the `$theme-alert-icon-size` default to `5` from `4`."
+ "\A - [Footer] We updated `usa-footer__logo-heading` to use a `p`."
+ "\A instead of an `h3`. "
+ "\A --------------------------------------------------------------------"
+ "\A 2.11.0:"
+ "\A - We updated some settings defaults:"
+ "\A $theme-alert-icon-size: 4 (was 5)"
+ "\A $theme-table-border-color: default (was 'ink')"
+ "\A $theme-table-header-text-color: default (was 'ink')"
+ "\A $theme-table-stripe-text-color: default (was 'ink')"
+ "\A $theme-table-text-color: default (was 'ink')"
+ "\A --------------------------------------------------------------------"
+ "\A 2.11.2:"
+ "\A - We deprecated the `$theme-site-max-width` variable. We're using"
+ "\A `$theme-grid-container-max-width` instead."
+ "\A - We replaced the `thumb_down_off_alt` icon with `thumb_down_alt`"
+ "\A in our default icon sprite."
+ "\A --------------------------------------------------------------------"
+ "\A 2.12.0:"
+ "\A - We deprecated three settings:"
+ "\A $theme-input-tile-background-color-selected"
+ "\A $theme-input-tile-border-color"
+ "\A $theme-input-tile-border-color-selected"
+ "\A Each of these is now calculated automatically"
+ "\A - We updated some settings defaults:"
+ "\A $theme-color-success-dark: green-cool-50v (was green-cool-50)"
+ "\A $theme-color-success-darker: green-cool-60v (was green-cool-80)"
+ "\A --------------------------------------------------------------------"
+ "\A 2.12.2:"
+ "\A - As a security precaution, we're now sanitizing text passed into "
+ "\A Tooltip. Tooltip no longer supports markup in its content."
+ "\A --------------------------------------------------------------------"
+ "\A 2.13.0:"
+ "\A BREAKING CHANGES:"
+ "\A - We made a couple breaking changes to support the accessibility"
+ "\A of icon-only buttons. See complete release notes:"
+ "\A https://github.com/uswds/uswds/releases/tag/v2.13.0"
+ "\A - We updated the markup of the small Search button to include its "
+ "\A magnifying glass icon as an inline image instead of as a "
+ "\A background image."
+ "\A See the release notes for the updated markup."
+ "\A - We updated the markup of the social icons in the Footer "
+ "\A to use inline images instead of background images."
+ "\A See the release notes for the updated markup.";
Comment on lines +127 to +138

@thisisdano thisisdano Dec 14, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the 2.13.0 notifications. We're highlighting the breaking changes and pointing users to the release notes for the markup updates. The release notes link will not be active until we publish the release.


/* prettier-ignore */
$uswds-notification-disable-message:
Expand Down