Visitar URL original
USWDS - Select: Include standard "multiple" stylings. Resolves #4423 by mahoneycm · Pull Request #4766 · uswds/uswds · GitHub
Skip to content

USWDS - Select: Include standard "multiple" stylings. Resolves #4423 #4766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 9 commits into from
Jul 5, 2022
Merged

USWDS - Select: Include standard "multiple" stylings. Resolves #4423 #4766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f372458
Creates multiple select styling
mahoneycm Jun 2, 2022
6d8e739
Begin creating test environment
mahoneycm Jun 2, 2022
7c8034f
Added options to test multiple select
mahoneycm Jun 3, 2022
e764357
Moves multiple select to it's own story
mahoneycm Jun 10, 2022
aff2aea
Refactored multiple select settings
mahoneycm Jun 13, 2022
3ca9f90
Moved multiple select to a test patterns directory
mahoneycm Jun 13, 2022
a9ebeec
Rename test story
mahoneycm Jun 14, 2022
6c53309
Remove extra lines
mahoneycm Jun 14, 2022
3d30ec0
Merge branch 'develop' of https://github.com/uswds/uswds into cm-sele…
Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/usa-select/src/styles/_usa-select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@
text-shadow: 0 0 0 color("black");
}

&[multiple] {
height: auto;
background-image: none;
}

// Necessary to show chevron in forced colors mode in modern browsers
@media (forced-colors: active) {
appearance: listbox; // Default <select> appearance value for modern browsers
Expand Down
12 changes: 12 additions & 0 deletions packages/usa-select/src/test/test-patterns/usa-select--multiple.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<form class="usa-form">
<label class="usa-label" for="options">Dropdown label</label>
<select class="usa-select" name="options" id="options" multiple size={{ size }} >
<option value>- Select -</option>
<option value="value1">Option A</option>
<option value="value2">Option B</option>
<option value="value3">Option C</option>
<option value="value1">Option E</option>
<option value="value2">Option F</option>
<option value="value3">Option G</option>
</select>
</form>
6 changes: 6 additions & 0 deletions packages/usa-select/src/usa-select.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
import Component from "./usa-select.twig";
import Test from "./test/test-patterns/usa-select--multiple.twig";

export default {
title: "Components/Form Inputs/Select",
};

const Template = (args) => Component(args);
const TestTemplate = (args) => Test(args);

export const Select = Template.bind({});
export const MultipleTest = TestTemplate.bind({});
MultipleTest.args = {
size: 0,
};