Visitar URL original
USWDS - HTMLProofer update broken links by amyleadem · Pull Request #4902 · uswds/uswds · GitHub
Skip to content

USWDS - HTMLProofer update broken links - #4902

Merged
thisisdano merged 1 commit into
developfrom
al-htmlproofer
Aug 5, 2022
Merged

thisisdano merged 1 commit into
developfrom
al-htmlproofer

Conversation

@amyleadem

@amyleadem amyleadem commented Aug 4, 2022 •

Copy link
Copy Markdown
Contributor

Summary

Remediate broken links found in updated HTMLProofer checks in USWDS-Site.
I simply deleted links when I could not find an alternative location via search. If anyone has more familiarity with these showcase sites, please confirm that deleting these items is the best course.

Related PR: uswds/uswds-site#1735
Related issue: uswds/uswds-site#1734

Preview link

Testing and review

To review:

  1. Confirm that updated urls work and point to the correct location.
  2. Confirm that the deleted links need to be removed (there is no alternate location the link can point to).
  3. Confirm that all items flagged in the USWDS-site al-htmlproofer branch are resolved.

HTMLProofer error report

From the al-htmlproofer branch on the USWDS-Site repo. (Related USWDS-Site PR: uswds/uswds-site#1735)

To reproduce:

  1. Open USWDS al-htmlproofer branch
  2. Run npm run proof in USWDS-Site, receive the errors below.
For the Links > External check, the following failures were found:

* At ./_site/about/security/index.html:2507:

  External link https://designsystem.digital.gov/documentation/developers/#download-and-install failed: https://designsystem.digital.gov/documentation/developers/ exists, but the hash 'download-and-install' does not (status code 200)

* At ./_site/about/security/index.html:2507:

  External link https://designsystem.digital.gov/documentation/developers/#install-using-npm failed: https://designsystem.digital.gov/documentation/developers/ exists, but the hash 'install-using-npm' does not (status code 200)

* At ./_site/documentation/developers/index.html:2849:

  External link https://github.com/uswds/uswds/releases/download/v3.1.0/uswds-uswds-3.1.0.tgz failed (status code 404)

* At ./_site/getting-started/showcase/all/index.html:2612:

  External link http://gipsa.usda.gov/ failed with something very wrong.
It's possible libcurl couldn't connect to the server, or perhaps the request timed out.
Sometimes, making too many requests at once also breaks things. (status code 0)

* At ./_site/getting-started/showcase/all/index.html:2624:

  External link https://openforest.fs.usda.gov/christmas-trees/forests failed with something very wrong.
It's possible libcurl couldn't connect to the server, or perhaps the request timed out.
Sometimes, making too many requests at once also breaks things. (status code 0)

* At ./_site/getting-started/showcase/all/index.html:2647:

  External link https://epa-notice.usa.gov/ failed with something very wrong.
It's possible libcurl couldn't connect to the server, or perhaps the request timed out.
Sometimes, making too many requests at once also breaks things. (status code 0)

* At ./_site/getting-started/showcase/all/index.html:2648:

  External link https://fardatacollection.sam.gov failed with something very wrong.
It's possible libcurl couldn't connect to the server, or perhaps the request timed out.
Sometimes, making too many requests at once also breaks things. (status code 0)

* At ./_site/getting-started/showcase/all/index.html:2660:

  External link https://federalist-report-template.18f.gov/ failed with something very wrong.
It's possible libcurl couldn't connect to the server, or perhaps the request timed out.
Sometimes, making too many requests at once also breaks things. (status code 0)

* At ./_site/getting-started/showcase/all/index.html:2665:

  External link https://hud-digital-services.github.io/single-family-policy-handbook/ failed (status code 404)

* At ./_site/getting-started/showcase/all/index.html:2672:

  External link http://gsa.github.io/openIAE/ failed: Not Found (status code 404)

* At ./_site/getting-started/showcase/all/index.html:2682:

  External link https://jobkit.data.gov/ failed with something very wrong.
It's possible libcurl couldn't connect to the server, or perhaps the request timed out.
Sometimes, making too many requests at once also breaks things. (status code 0)

* At ./_site/getting-started/showcase/all/index.html:2689:

  External link https://meps.ahrq.gov/mepstrends/home/index.html failed (status code 401)

* At ./_site/getting-started/showcase/all/index.html:2710:

  External link https://omb-eregs-demo.app.cloud.gov/ failed (status code 404)

* At ./_site/getting-started/showcase/all/index.html:2727:

  External link https://match.state.gov/ failed with something very wrong.
It's possible libcurl couldn't connect to the server, or perhaps the request timed out.
Sometimes, making too many requests at once also breaks things. (status code 0)

* At ./_site/getting-started/showcase/all/index.html:2735:

  External link http://alexose.github.io/experiments/correspondence/ failed: Not Found (status code 404)

HTML-Proofer found 15 failures!

Before opening this PR, make sure you’ve done whichever of these applies to you:

  • Run git pull origin [base branch] to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch is develop).
  • Run npm test and confirm that all tests pass.

- [Login.gov](https://www.login.gov/)
- [Manufacturing USA](https://www.manufacturing.gov/)
- [Medicaid](https://www.medicaid.gov/)
- [Medical Expenditure Panel Survey (MEPS) summary tables](https://meps.ahrq.gov/mepstrends/home/index.html)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Password protected - Requires login

@amyleadem
amyleadem marked this pull request as ready for review August 5, 2022 13:50
@amyleadem
amyleadem requested a review from mejiaj August 5, 2022 13:50
@thisisdano
thisisdano merged commit 7b3cb67 into develop Aug 5, 2022
@thisisdano
thisisdano deleted the al-htmlproofer branch August 5, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants