Repository navigation
USWDS - HTMLProofer update broken links - #4902
Merged
Merged
Conversation
1 of 2 tasks
amyleadem
commented
Aug 5, 2022
| - [Login.gov](https://www.login.gov/) | ||
| - [Manufacturing USA](https://www.manufacturing.gov/) | ||
| - [Medicaid](https://www.medicaid.gov/) | ||
| - [Medical Expenditure Panel Survey (MEPS) summary tables](https://meps.ahrq.gov/mepstrends/home/index.html) |
Contributor
Author
There was a problem hiding this comment.
Password protected - Requires login
amyleadem
marked this pull request as ready for review
August 5, 2022 13:50
thisisdano
approved these changes
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediate broken links found in updated HTMLProofer checks in USWDS-Site.
I simply deleted links when I could not find an alternative location via search. If anyone has more familiarity with these showcase sites, please confirm that deleting these items is the best course.
Related PR: uswds/uswds-site#1735
Related issue: uswds/uswds-site#1734
Preview link
Testing and review
To review:
al-htmlprooferbranch are resolved.HTMLProofer error report
From the
al-htmlprooferbranch on the USWDS-Site repo. (Related USWDS-Site PR: uswds/uswds-site#1735)To reproduce:
al-htmlprooferbranchnpm run proofin USWDS-Site, receive the errors below.Before opening this PR, make sure you’ve done whichever of these applies to you:
git pull origin [base branch]to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch isdevelop).npm testand confirm that all tests pass.