Visitar URL original
USWDS - Core: Deprecate font-smoothing mixins by mejiaj · Pull Request #5250 · uswds/uswds · GitHub
Skip to content

USWDS - Core: Deprecate font-smoothing mixins #5250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 1 commit into from
May 8, 2023
Merged

USWDS - Core: Deprecate font-smoothing mixins #5250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/usa-dark-background/src/styles/_usa-dark-background.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
@use "uswds-core" as *;

.usa-dark-background {
@include add-knockout-font-smoothing;
background-color: color("base-darker");

p,
Expand Down
11 changes: 11 additions & 0 deletions packages/uswds-core/src/styles/_deprecated.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,14 @@ $output-all-utilities: true !default;
@mixin embed-container($height, $width) {
padding-bottom: math.percentage(math.div($height, $width));
}

$font-smoothing-warning: "Font smoothing was deprecated in USWDS 3.5.0. Please remove any references to it.";

// Deprecated in 3.5.0
@mixin add-knockout-font-smoothing {
@warn $font-smoothing-warning;
}

@mixin no-knockout-font-smoothing {
@warn $font-smoothing-warning;
}
Comment on lines +30 to +39

@thisisdano thisisdano May 8, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for remembering this

1 change: 0 additions & 1 deletion packages/uswds-core/src/styles/mixins/general/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
@forward "add-bar";
@forward "add-checkbox-placeholder";
@forward "add-kerning";
@forward "add-knockout-font-smoothing";
@forward "add-responsive-site-margins";
@forward "add-success-mark";
@forward "button-disabled";
Expand Down
9 changes: 0 additions & 9 deletions packages/uswds-core/src/styles/mixins/general/add-knockout-font-smoothing.scss
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions packages/uswds-core/src/styles/mixins/general/button-disabled.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@use "./add-knockout-font-smoothing" as *;
@use "../../functions" as *;

@mixin button-disabled {
@include add-knockout-font-smoothing;
background-color: color("disabled");
color: color("white");
cursor: auto;
Expand Down
3 changes: 0 additions & 3 deletions packages/uswds-core/src/styles/mixins/general/button-unstyled.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@
@use "../../mixins/utilities" as *;
@use "../typography/usa-prose" as *;
@use "../typography/typeset" as *;
@use "add-knockout-font-smoothing" as *;

@mixin button-unstyled {
@include no-knockout-font-smoothing;
@include typeset-link;
background-color: transparent;
border: 0;
Expand Down Expand Up @@ -42,7 +40,6 @@
&:disabled,
&[aria-disabled="true"],
&.usa-button--disabled {
@include no-knockout-font-smoothing;
background-color: transparent;
box-shadow: none;
text-decoration: underline;
Expand Down