Visitar URL original
USWDS - Footer: Fix link styles for accessibility by mahoneycm · Pull Request #5588 · uswds/uswds · GitHub
Skip to content

USWDS - Footer: Fix link styles for accessibility #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 2 commits into from
Oct 30, 2023
Merged

USWDS - Footer: Fix link styles for accessibility #5588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7689673
Restore link underlines in default states
mahoneycm Oct 30, 2023
403bd20
Remove redundant hover styles
mahoneycm Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions packages/usa-footer/src/styles/_usa-footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,29 +77,16 @@ $-chevron-expand-more: map-merge(
line-height: line-height($theme-footer-font-family, 2);
}

.usa-footer__primary-link a,
.usa-footer__secondary-link a {
text-decoration: none;

&:hover {
text-decoration: underline;
}
}

.usa-footer__primary-link {
@include u-padding-x($theme-site-margins-mobile-width);
@include u-padding-y(2);
@include u-text("ink", "no-underline", "bold");
@include u-text("ink", "bold");

@mahoneycm mahoneycm Oct 30, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing no-underline from u-text() mixin properly applies color and weight without causing any unintentional regressions.

display: block;

@include at-media("mobile-lg") {
@include u-padding-x(0);
}

&:hover {
text-decoration: underline;
}

Comment on lines -99 to -102

@mahoneycm mahoneycm Oct 30, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styles redundant due to primary links having an underline in default states now

// Disclosure button functionality happens at mobile widths
&--button {
@include place-icon($-chevron-expand-more, "before", 0.5);
Expand Down Expand Up @@ -166,11 +153,7 @@ $-chevron-expand-more: map-merge(
line-height: line-height($theme-footer-font-family, 2);

a {
@include u-text("ink", "no-underline");

&:hover {
text-decoration: underline;
}
Comment on lines -169 to -173

@mahoneycm mahoneycm Oct 30, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional styles redundant due to primary links having an underline in default states now

@include u-text("ink");
}

@include at-media("mobile-lg") {
Expand Down