Visitar URL original
USWDS 3.7.0 by thisisdano · Pull Request #5605 · uswds/uswds · GitHub
Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
128 commits
Select commit Hold shift + click to select a range
eeed2c1
Utilize behaviors on modal
mahoneycm Mar 27, 2023
11fc665
Add modalId conditional statement before running setUpModal
mahoneycm Mar 27, 2023
b634bd1
Refine modal behaviors & conditional statement
mahoneycm Mar 28, 2023
1f972ce
Run prettier formatting
Apr 6, 2023
ee866c9
Comment adjustments
mahoneycm Apr 7, 2023
1c51556
Replace selectAll with selectOrMatches
mahoneycm Apr 7, 2023
4e13fc0
Merge branch 'cm-modal-behavior' of github.com:uswds/uswds into cm-mo…
mahoneycm Apr 7, 2023
24a90b7
Update modalTrigger anchor comments
mahoneycm Apr 7, 2023
0988c22
Move modalTrigger selector from root to document to resolve unit test
mahoneycm Apr 7, 2023
76b3f21
Modify conditional statement and add check to teardown
mahoneycm May 2, 2023
a37296c
Refactor setUpModal into multiple functions
mahoneycm May 12, 2023
fcc6aff
Refactor placeholder attribute loop
mahoneycm May 31, 2023
d74192c
Add error messages and refactor cleanUpModal attribute loop to match
mahoneycm Jun 1, 2023
417b41f
Prettier:js
mahoneycm Jun 1, 2023
fc4e134
Merge branch 'develop' of github.com:uswds/uswds into cm-refactor-modal
mahoneycm Jun 1, 2023
aceec33
Merge branch 'develop' of github.com:uswds/uswds into cm-refactor-modal
mahoneycm Jul 5, 2023
cdd38a0
Remove redundant aria label checks
mahoneycm Jul 10, 2023
a5879b4
Remove comment
mahoneycm Jul 10, 2023
0e34893
Update function comments
mahoneycm Jul 10, 2023
270c293
Simplify rebuildModal to be more readable
mahoneycm Jul 10, 2023
d5225f8
Run prettier && lint
mahoneycm Jul 10, 2023
01b190e
Remove log
mahoneycm Jul 10, 2023
660bb58
JSDoc comment cleanup
mahoneycm Jul 11, 2023
9e57309
Run prettier && lint
mahoneycm Jul 11, 2023
b6f4ffd
Update table rolls
mahoneycm Jul 12, 2023
60643e0
Comment out grid role from table
mahoneycm Jul 17, 2023
5a4f4bb
Try role application
mahoneycm Jul 17, 2023
4b3564d
Set wrapper div to role='application'
mahoneycm Jul 25, 2023
c84d5ed
Update JSDoc comments per recommendations
mahoneycm Jul 25, 2023
568be81
Revert table role to dialog
mahoneycm Jul 26, 2023
348200a
Revert table role to dialog
mahoneycm Jul 26, 2023
47493cd
Set table role back to application; add aria-label
mahoneycm Jul 26, 2023
e519bf1
Swap remaining modalWrapper const names to modalContentWrapper to mai…
mahoneycm Jul 26, 2023
a510f42
Test moving aria-label to table
mahoneycm Jul 28, 2023
7d18e84
Remove aria-modal and label
mahoneycm Jul 28, 2023
d6b978d
Change table wrapper role to presentation
mahoneycm Jul 28, 2023
3d2618a
Revert table wrapper to role application
mahoneycm Jul 31, 2023
bbeb493
Restore presentation roles to year and month calendars
mahoneycm Jul 31, 2023
dc16e4f
Merge branch 'develop' of github.com:uswds/uswds into cm-date-picker-…
mahoneycm Jul 31, 2023
dfe24c7
Remove redundant aria attributes from usa-range
mahoneycm Aug 1, 2023
3989aa0
Merge branch 'develop' of github.com:uswds/uswds into cm-refactor-modal
mahoneycm Aug 28, 2023
e926de8
Merge branch 'develop' of github.com:uswds/uswds into cm-date-picker-…
mahoneycm Aug 28, 2023
d558beb
Merge branch 'develop' of github.com:uswds/uswds into cm-range-slider-sr
mahoneycm Aug 28, 2023
9d4cd78
Create range js file
mahoneycm Aug 28, 2023
8319e5f
Enhance range story controls and create unit story
mahoneycm Aug 28, 2023
dd365f1
Merge branch 'develop' of github.com:uswds/uswds into cm-range-slider…
mahoneycm Aug 29, 2023
baed12c
Run prettier
mahoneycm Aug 29, 2023
f6b1d62
Change default step value back to 10
mahoneycm Aug 30, 2023
c0ff362
Unit test start; currently failing
mahoneycm Aug 30, 2023
b739f09
Fix and improve range slider unit test
mahoneycm Sep 7, 2023
ae58c28
Run prettier
mahoneycm Sep 7, 2023
b249552
Add aria-hidden to "An" in "official website of"
Sep 7, 2023
5af2fda
Remove 'click to' language from date picker
mahoneycm Sep 14, 2023
8d7da48
Update range slider event listener to change instead of input
mahoneycm Sep 18, 2023
f79ec30
Merge pull request #5537 from uswds/main
thisisdano Sep 29, 2023
c484bbb
Optimize banner flag icon, provide vector option
aduth Oct 4, 2023
97f0586
Bump postcss from 8.4.19 to 8.4.31
dependabot[bot] Oct 5, 2023
87f4587
USWDS - Site Alert - Repair top margin, broken by #4922
lpsinger Oct 8, 2023
27181af
Add init to Banner
Oct 8, 2023
d85e727
Add comment to toggleBanner function
Oct 10, 2023
f6d1695
Remove accordion dependency from banner.
Oct 10, 2023
48bfdf2
Merge pull request #5543 from uswds/dependabot/npm_and_yarn/postcss-8…
Oct 11, 2023
99de929
Use prefix and separate banner button class in accordion
Oct 11, 2023
51a4f43
Use node LTS 18
Oct 12, 2023
7bc766a
Update style & webpack dependencies
Oct 12, 2023
408e75e
Revert to prettier v2
Oct 12, 2023
517ad2d
Bump storybookJS deps to last 6x patch
Oct 13, 2023
e9a3f4a
Update utility deps; logging, SVG, typescript
Oct 13, 2023
c45e695
Merge branch 'develop' of github.com:uswds/uswds into cm-refactor-modal
mahoneycm Oct 16, 2023
9e0d349
Update js docs
mahoneycm Oct 18, 2023
5d2afeb
Removed enhanceSRContext
mahoneycm Oct 18, 2023
cbfe406
Implement optional preposition data attribute
mahoneycm Oct 18, 2023
2ec5398
Run prettier
mahoneycm Oct 19, 2023
c540d35
Export updateCallout
mahoneycm Oct 19, 2023
182065e
Update "math.div($theme-card-padding-y" references
Oct 20, 2023
80ce058
Revert lang
mahoneycm Oct 26, 2023
aa25daa
Update data attribute names
mahoneycm Oct 26, 2023
85b58fe
Update unit tests
mahoneycm Oct 26, 2023
06078d7
Fix math errors with $theme-site-margins-width
Oct 26, 2023
460028c
Add icon template
thisisdano Oct 27, 2023
44ba1d9
Add optimized X logo
thisisdano Oct 27, 2023
951c140
Add X icon to sprite config
thisisdano Oct 27, 2023
9a3bd2a
Add X icon to storybook
thisisdano Oct 27, 2023
52c1f47
Remove square background
thisisdano Oct 27, 2023
061afc0
Adjust optical balance
thisisdano Oct 27, 2023
0fb7e08
Adjust optical balance
thisisdano Oct 27, 2023
944db02
Update preposition logic and JSDocs comment
mahoneycm Oct 30, 2023
c63d900
Add preposition storybook control hint
mahoneycm Oct 30, 2023
b178a10
Run prettier
mahoneycm Oct 30, 2023
ffaf62b
Run linter
mahoneycm Oct 30, 2023
7689673
Restore link underlines in default states
mahoneycm Oct 30, 2023
403bd20
Remove redundant hover styles
mahoneycm Oct 30, 2023
36e3929
Add additional package updates
thisisdano Oct 30, 2023
ba52cb7
Update package-lock.json
thisisdano Oct 30, 2023
13944d6
Try current Node LTS 20.9.0
thisisdano Oct 30, 2023
56e69ea
Update circle image
thisisdano Oct 30, 2023
c5b94aa
Merge pull request #5560 from uswds/jm-feature-node-18-update
thisisdano Oct 30, 2023
9c6fb51
Merge pull request #5374 from uswds/cm-date-picker-jaws-table-attr
thisisdano Oct 30, 2023
8e2dcb0
Merge pull request #5551 from uswds/jm-feature-banner-init
thisisdano Oct 30, 2023
2eec2cd
Merge pull request #5315 from uswds/cm-refactor-modal
thisisdano Oct 30, 2023
5069857
Merge pull request #5588 from uswds/cm-update-footer-link-styles
thisisdano Oct 30, 2023
4993d2c
Merge pull request #5413 from uswds/cm-range-slider-sr
thisisdano Oct 30, 2023
9b27532
Merge pull request #5491 from uswds/al-identifier-text
thisisdano Oct 30, 2023
105e11b
Merge pull request #5542 from aduth/aduth-compress-us-flag
thisisdano Oct 30, 2023
8f557ca
Merge branch 'main' of github.com:uswds/uswds into cm-range-slider-sr…
mahoneycm Oct 31, 2023
05d7744
Merge branch 'develop' of github.com:uswds/uswds into cm-range-slider…
mahoneycm Oct 31, 2023
30e1d2b
Update callout logic to remove extra space from callout
mahoneycm Oct 31, 2023
b06a84f
Set default value for max based on range sliders default max value
mahoneycm Nov 1, 2023
39cca2b
Added clarity and normalization to unit tests
mahoneycm Nov 1, 2023
05e8953
Restore default unit test src
mahoneycm Nov 1, 2023
f2c7b65
Run prettier
mahoneycm Nov 1, 2023
64e7dec
Merge pull request #5582 from uswds/al-theme-site-margins-fix
thisisdano Nov 2, 2023
8c5963f
Merge pull request #5589 from uswds/dw-add-x-icon
thisisdano Nov 2, 2023
5e3dd52
Merge pull request #5550 from lpsinger/usa-site-alert-fix-top-margin
thisisdano Nov 2, 2023
8f92ea7
Merge pull request #5571 from uswds/al-card-padding-calc
thisisdano Nov 2, 2023
1655dff
Merge branch 'develop' of https://github.com/uswds/uswds into cm-rang…
Nov 2, 2023
494c3c2
Add comment to max attribute definition
amyleadem Nov 2, 2023
57fecbb
Edit comment examples to remove role; add prep example
amyleadem Nov 2, 2023
8f6c1f6
Merge branch 'cm-range-slider-sr-unit' of https://github.com/uswds/us…
Nov 2, 2023
3657969
Run prettier
Nov 2, 2023
4a1f9fb
Merge pull request #5472 from uswds/cm-range-slider-sr-unit
thisisdano Nov 6, 2023
84c7767
Add 3.7.0 notifications
thisisdano Nov 9, 2023
3a5af8d
Update references to 3.7.0
thisisdano Nov 9, 2023
4eca834
Use consistent wording
thisisdano Nov 9, 2023
eeaa055
Simplify content
thisisdano Nov 9, 2023
84c78d8
Merge pull request #5603 from uswds/dw-update-notifications-3.7.0
thisisdano Nov 9, 2023
574e57f
3.7.0
thisisdano Nov 9, 2023
e670ce3
Create uswds-3.7.0-zip-hash.txt
thisisdano Nov 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Set default value for max based on range sliders default max value
  • Loading branch information
mahoneycm committed Nov 1, 2023
commit b06a84f772290ec6f15aa5645256c762199467cc
2 changes: 1 addition & 1 deletion packages/usa-range/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const updateCallout = (targetRange) => {
const prep = optionalPrep || defaultPrep;
const unit = rangeSlider.dataset.textUnit;
const val = rangeSlider.value;
const max = rangeSlider.getAttribute("max");
const max = rangeSlider.getAttribute("max") || 100;

let callout;

Expand Down