Visitar URL original
USWDS - Identifier: Fix content prefix bug in html-templates by amyleadem · Pull Request #5857 · uswds/uswds · GitHub
Skip to content

USWDS - Identifier: Fix content prefix bug in html-templates #5857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 5 commits into from
May 22, 2024
Merged

USWDS - Identifier: Fix content prefix bug in html-templates #5857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ec7a2f
Explicitly set content_prefix to null > es versions
Apr 9, 2024
13c2f31
Update Spanish usa.gov link
Apr 10, 2024
72b5a7c
Update data for identifier.twig
Apr 10, 2024
1877f24
Update "USA.gov en Español" > "USAGov en Español"
Apr 10, 2024
3b4c811
Revert usagov link label and url for es
Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/templates/usa-base/includes/_identifier.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
'masthead': {
'aria_label': 'Agency identifier',
'description': 'Agency description',
'content': 'An official website of the',
'content_prefix': 'An',
'content': 'official website of the',
'parent': {
'name': '<Parent agency>',
'shortname': '<Parent shortname>',
Expand Down
1 change: 1 addition & 0 deletions packages/usa-identifier/src/content/usa-identifier~lang-es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"masthead": {
"aria_label": "Identificador de la agencia,",
"description": "Descripción de la agencia,",
"content_prefix": null,

@mejiaj mejiaj Apr 25, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, it seems like the Spanish prefix here would be Un.

@mahoneycm mahoneycm Apr 26, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I brought up the same thing in this thread but Amy clarified that this attribute is used to ignore An in an official because it sounds like "unofficial". We shouldn't need to ignore the prefix in the Spanish variant!

"content": "Un sitio web oficial de",
"parent": {
"name": "<Parent agency>",
Expand Down
1 change: 1 addition & 0 deletions packages/usa-identifier/src/content/usa-identifier~multiple-logos-lang-es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"masthead": {
"aria_label": "Identificador de la agencia,,,",
"description": "Descripción de la agencia,,,",
"content_prefix": null,
Comment thread
mahoneycm marked this conversation as resolved.
"content": "Un sitio web oficial de",
"parent": {
"name": "<Parent agency>",
Expand Down
1 change: 1 addition & 0 deletions packages/usa-identifier/src/content/usa-identifier~no-logos-lang-es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"masthead": {
"aria_label": "Identificador de la agencia,,",
"description": "Descripción de la agencia,,",
"content_prefix": null,
"content": "Un sitio web oficial de",
"parent": {
"name": "<Parent agency>",
Expand Down
1 change: 1 addition & 0 deletions packages/usa-identifier/src/content/usa-identifier~taxpayer-disclaimer-lang-es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"masthead": {
"aria_label": "Identificador de la agencia,,,,",
"description": "Descripción de la agencia,,,,",
"content_prefix": null,
"content": "Un sitio web oficial de",
"parent": {
"name": "<Parent agency>",
Expand Down