Visitar URL original
USWDS - Button group: Fix margins on nested button groups by amyleadem · Pull Request #5885 · uswds/uswds · GitHub
Skip to content

USWDS - Button group: Fix margins on nested button groups #5885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 11 commits into from
May 22, 2024
Merged

USWDS - Button group: Fix margins on nested button groups #5885

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2317fe4
Add nested button group test story
Apr 19, 2024
48ff5d8
Move styles to .scss; add explanation for test results
Apr 24, 2024
4f65fec
Add styles for nested button groups
Apr 24, 2024
b8dd1d8
Remove disabled_state controls for test stories
Apr 24, 2024
80b6657
Merge branch 'develop' of https://github.com/uswds/uswds into al-butt…
Apr 29, 2024
3fcab66
Replace maxw w/ responsive width-
Apr 29, 2024
5a2b5d5
Update y margins on nested buttons
Apr 29, 2024
f4e7bd7
Replace anchor links with button elements
Apr 29, 2024
8a926e3
Remove flex from nested items
May 3, 2024
85f2945
Update naming convention for button group tests
May 3, 2024
df884c8
Fix button group indents in nested test
May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move styles to .scss; add explanation for test results
  • Loading branch information
amyleadem
amyleadem committed Apr 24, 2024
commit 48ff5d8aa1b98b6989bd0d6d8ef04dd2d7a54c62
17 changes: 9 additions & 8 deletions packages/usa-button-group/src/test/test-patterns/usa-button-group--test-nested.twig
View file
Open in desktop
Comment thread
mejiaj marked this conversation as resolved.
Resolved

@mejiaj mejiaj May 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test prefix is added at the start of the filename. For example: test-usa-button-group--nested.twig.

I realize component template is hardcoded, but in the future we should avoid additional hardcoded components to allow for easier test template creation. As-is this hardcoded test template is okay.

@amyleadem amyleadem May 3, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the file names in the button group /test-patterns/ directory to reflect the common naming convention for these files in 85f2945

Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<style>
.usa-button-group__item {
margin-top:0;
margin-bottom:0;
display: flex;
}
</style>
<div class="usa-prose measure-5 padding-2 border-1px border-gray-20 margin-bottom-4">
<p class="font-body-lg text-bold margin-top-0">Test nested button groups</p>
<p>Confirm that buttons inside nested button groups are:</p>
<ul>
<li>The same height as their sibling buttons</li>
<li>The same height as their parent buttons</li>
</ul>
</div>

<h3>Nested button group</h3>
<ul class="usa-button-group">
Expand Down Expand Up @@ -35,7 +36,7 @@
<a href="#" class="usa-button usa-button--outline maxw-15">Button with long text </a>
</li>
<li class="usa-button-group__item">
<ul class="usa-button-group">
<ul class="usa-button-group usa-button-group--segmented">
<li class="usa-button-group__item">
<a href="#" class="usa-button usa-button--outline maxw-10">Nested Button</a>
</li>
Expand Down