Visitar URL original
USWDS - Footer: Show overflow (for focus rings) by 6TELOIV · Pull Request #6093 · uswds/uswds · GitHub
Skip to content

USWDS - Footer: Show overflow (for focus rings) #6093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6TELOIV wants to merge 4 commits into from
Closed

USWDS - Footer: Show overflow (for focus rings) #6093

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6b835e
Show focus ring on footer.
6TELOIV Oct 4, 2024
5333a57
Merge branch 'uswds:develop' into footer-overflow-focus-ring-fix
6TELOIV Nov 13, 2024
91db444
Fix regression for border on footer links overflow
6TELOIV Nov 13, 2024
b1f4646
Fix regression for footer primary link buttons
6TELOIV Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions packages/usa-footer/src/styles/_usa-footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ $-chevron-expand-more: map-merge(
.usa-footer {
@include border-box-sizing;
@include typeset($theme-footer-font-family);
overflow: hidden;

> .grid-container {
@include grid-container($theme-footer-max-width);
Expand Down Expand Up @@ -81,16 +80,19 @@ $-chevron-expand-more: map-merge(
@include u-padding-y(2);
@include u-text("ink", "bold");
display: block;
// Border reset for button variants of footer primary links.
border: 0;
border-top: 1px solid color("base-light");

@include at-media("mobile-lg") {
border: none;
@include u-padding-x(0);
}

// Disclosure button functionality happens at mobile widths
&--button {
@include place-icon($-chevron-expand-more, "before", 0.5);
width: 100%;
border: 0;
cursor: pointer;

&:not([disabled]):focus {
Expand Down Expand Up @@ -161,14 +163,6 @@ $-chevron-expand-more: map-merge(
}
}

.usa-footer__primary-content {
border-top: 1px solid color("base-light");

@include at-media("mobile-lg") {
border: none;
}
}

Comment thread
6TELOIV marked this conversation as resolved.
Resolved
.usa-sign-up {
padding-bottom: units(4);
padding-top: units(3);
Expand Down