Visitar URL original
USWDS - Step indicator: Remove aria-label from wrapper by amyleadem · Pull Request #6146 · uswds/uswds · GitHub
Skip to content

USWDS - Step indicator: Remove aria-label from wrapper #6146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 1 commit into from
Nov 6, 2024
Merged

USWDS - Step indicator: Remove aria-label from wrapper #6146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/usa-step-indicator/src/usa-step-indicator.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="usa-step-indicator {{ modifier }}" aria-label="progress">
<div class="usa-step-indicator {{ modifier }}">

@mahoneycm mahoneycm Oct 24, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note (non-blocking): I noticed that my screen reader no longer focuses the entire time picker "group".

Before:

  1. Screen reader focuses entire component group
  2. Screen reader then focuses step indicator bar and reads through steps
  3. Screen reader then reads out header element

After:

  1. Screen reader focuses step indicator bar and reads through steps
  2. Screen reader then focuses header element

This doesn't seem to be an issue but wanted to flag since the behavior changes slightly

@amyleadem amyleadem Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging!

@amycole501 and @alex-hull, would this change in behavior count as an accessibility regression? Wanting to check in with you both before moving forward with this.

@alex-hull alex-hull Oct 24, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Charlie. I don't think this will be an issue. It appears that the flow is not that much different between the before and after interaction, so that should not be too big of a change. I also think as long as the user hears what current step they are on, this should not be an issue. @amyleadem

<ol class="usa-step-indicator__segments"{% if noLabels %} aria-hidden="true"{% endif %}>
{% for step in steps %}
<li class="usa-step-indicator__segment{% if step.status == "complete" %} usa-step-indicator__segment--complete{% endif %}{% if step.status == "current" %} usa-step-indicator__segment--current{% endif %}"{% if step.status == "current" and showLabels %} aria-current="true"{% endif %}>
Expand Down