Visitar URL original
USWDS - Time picker: Add clarity to hint text by amyleadem · Pull Request #6147 · uswds/uswds · GitHub
Skip to content

USWDS - Time picker: Add clarity to hint text #6147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annepetersen merged 3 commits into from
Nov 6, 2024
Merged

USWDS - Time picker: Add clarity to hint text #6147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd9f992
Update time picker hint text
Oct 23, 2024
95e832b
Add clarity to hint text
amyleadem Oct 24, 2024
f8004cc
Add clarity to hint text
Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions packages/usa-form/src/test/test-pattern/test-usa-form.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
{% endif %}

{# *
* While we could add the usa-form-group--error class to <form class="usa-form"> elements, we should
* While we could add the usa-form-group--error class to <form class="usa-form"> elements, we should
* avoid doing this and only add it to usa-form-group elements.
*
* Setting the error on the form element would add the error class to the entire form and not just
* Setting the error on the form element would add the error class to the entire form and not just
* the form question that holds the error.
*#}
<form class="usa-form">
Expand All @@ -34,7 +34,7 @@


{# *
* usa-legend and usa-label output the same base styles. Because of this, we can add the
* usa-legend and usa-label output the same base styles. Because of this, we can add the
* usa-label--error class without any additional changes or unexpected style conflicts.
*#}
<div class="usa-form-group {% if error_state == true %}usa-form-group--error{% endif %}">
Expand Down Expand Up @@ -73,7 +73,7 @@
</div>

{# *
* In order for the red border to highlight the form input with an error, the elements must be
* In order for the red border to highlight the form input with an error, the elements must be
* nested within a div with the usa-form-group and usa-form-group--error classes.
*#}
<div class="usa-form-group {% if error_state == true %}usa-form-group--error{% endif %}">
Expand Down Expand Up @@ -111,9 +111,9 @@
</fieldset>
</div>

{# !
! Adding the usa-input--error class to the combo box nested select element does not carry the class over to
! its dynamically placed input element. The class remains on the hidden select element. This is true for time picker's
{# !
! Adding the usa-input--error class to the combo box nested select element does not carry the class over to
! its dynamically placed input element. The class remains on the hidden select element. This is true for time picker's
! combo box element as well.
!#}
<div class="usa-form-group {% if error_state == true %}usa-form-group--error{% endif %}">
Expand Down Expand Up @@ -167,11 +167,11 @@
/>
</div>

{# !
{# !
! Input mask breaks due to DOM structure changing. Related to: #5517.
!
! This initialization error also causes subsequent JS files to not initialize properly.
! On this page, time picker does not initialize. Removing input-mask or the error states will allow time
! This initialization error also causes subsequent JS files to not initialize properly.
! On this page, time picker does not initialize. Removing input-mask or the error states will allow time
! picker to properly initialize.
!#}
<form class="usa-form">
Expand All @@ -193,9 +193,9 @@
{% if error_state == true %}</div>{% endif %}
</form>

{# *
{# *
* Input prefix/suffix input group
* For input prefix/suffix, the usa-input--error class must be put on the usa-input-group element in order for
* For input prefix/suffix, the usa-input--error class must be put on the usa-input-group element in order for
* the styles to display as expected
*#}
<form class="usa-form">
Expand Down Expand Up @@ -359,14 +359,14 @@
</div>

{# !
! Due to Combo box's dynamic input element not receiving the same classes as it's select placeholder,
! Due to Combo box's dynamic input element not receiving the same classes as it's select placeholder,
! the error input classes are not set on initialization
!#}
<div class="usa-form-group {% if error_state == true %}usa-form-group--error{% endif %}">
<label class="usa-label {% if error_state == true %}usa-label--error{% endif %}" id="appointment-time-label" for="appointment-time"
>Time picker</label
>
<div class="usa-hint" id="appointment-time-hint">hh:mm</div>
<div class="usa-hint" id="appointment-time-hint">Select a time from the dropdown. Type into the input to filter options.</div>
{% if error_state == true %}<span class="usa-error-message" role="alert">Helpful error message</span>{% endif %}
<div class="usa-time-picker">
<input
Expand Down
2 changes: 1 addition & 1 deletion packages/usa-time-picker/src/usa-time-picker.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="usa-form-group">
<label class="usa-label" id="appointment-time-label" for="appointment-time">Appointment time</label>
<div class="usa-hint" id="appointment-time-hint">hh:mm</div>
<div class="usa-hint" id="appointment-time-hint">Select a time from the dropdown. Type into the input to filter options.</div>
<div class="usa-time-picker">
<input
class="usa-input"
Expand Down