Visitar URL original
USWDS - Footer: Fix overflow focus cutoff and padding by amyleadem · Pull Request #6237 · uswds/uswds · GitHub
Skip to content

USWDS - Footer: Fix overflow focus cutoff and padding #6237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 5 commits into from
Dec 16, 2024
Merged

USWDS - Footer: Fix overflow focus cutoff and padding #6237

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6b835e
Show focus ring on footer.
6TELOIV Oct 4, 2024
5333a57
Merge branch 'uswds:develop' into footer-overflow-focus-ring-fix
6TELOIV Nov 13, 2024
91db444
Fix regression for border on footer links overflow
6TELOIV Nov 13, 2024
b1f4646
Fix regression for footer primary link buttons
6TELOIV Dec 2, 2024
f86a6d3
Remove x padding on .usa-footer__primary-container
Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove x padding on .usa-footer__primary-container
  • Loading branch information
amyleadem
amyleadem committed Dec 3, 2024
commit f86a6d3aa1fcd6d345dfc6402b0336baba98b890
5 changes: 3 additions & 2 deletions packages/usa-footer/src/styles/_usa-footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ $-chevron-expand-more: map-merge(

.usa-footer__primary-container {
@include grid-container($theme-footer-max-width);
@include u-padding-x(0);

@amyleadem amyleadem Dec 3, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This is the only meaningful change from #6093. All other changes are just re-ordering the style rules to match convention.

@6TELOIV 6TELOIV Dec 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me! Both issues are fairly related, so getting both done in one pull makes sense to me


@include at-media("desktop") {
@include u-padding-x(4);
Expand All @@ -79,14 +80,14 @@ $-chevron-expand-more: map-merge(
@include u-padding-x($theme-site-margins-mobile-width);
@include u-padding-y(2);
@include u-text("ink", "bold");
display: block;
// Border reset for button variants of footer primary links.
border: 0;
border-top: 1px solid color("base-light");
display: block;

@include at-media("mobile-lg") {
border: none;
@include u-padding-x(0);
border: none;
}

// Disclosure button functionality happens at mobile widths
Expand Down