Visitar URL original
USWDS - SASS: Address map deprecation warnings by mejiaj · Pull Request #6519 · uswds/uswds · GitHub
Skip to content

USWDS - SASS: Address map deprecation warnings - #6519

Merged
ethangardner merged 9 commits into
uswds:developfrom
mejiaj:jm-sass-map-deprecations
Jul 6, 2026
Merged

ethangardner merged 9 commits into
uswds:developfrom
mejiaj:jm-sass-map-deprecations

Conversation

@mejiaj

@mejiaj mejiaj commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

Summary

This work replaces deprecated SASS map-merge and map-has-key. It avoids issues when SASS updates and gets rid of 23 warnings (469 [develop] → 446 [this branch]).

Breaking change

This is not a breaking change.

Related issue

Part of #6216.

Solution

Uses new map functions based on SASS map guidance.

Major changes

Updated map methods and imported sass:map with @use "sass:map"; where it was missing.

Testing and review

  • There shouldn't be any errors on compile
  • Map warnings should be gone on compile
  • There shouldn't be any visual regressions in: Accordion, Banner, Combo box, Date picker (and range), Footer, Icon list, Navigation, Add Aspect, and Layout (at-media).

@github-actions

Copy link
Copy Markdown
Contributor

✅ All commits on this PR have a verified signature. Thanks!

@jonathanbobel jonathanbobel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ran fine locally.

@ethangardner
ethangardner merged commit ba9325d into uswds:develop Jul 6, 2026
6 checks passed
@ethangardner ethangardner added this to the uswds 3.14.0 - Aug 2026 milestone Aug 4, 2026
@chandracarney chandracarney moved this from Triage to Done in USWDS Core Project Data Aug 21, 2026
@github-project-automation github-project-automation Bot moved this from Done to Fed Final Review in USWDS Core Project Data Aug 21, 2026
@chandracarney chandracarney moved this from Fed Final Review to Done in USWDS Core Project Data Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants