Visitar URL original
fix: prevent console error when using datalist with text inputs by vijaygovindaraja · Pull Request #6594 · uswds/uswds · GitHub
Skip to content

fix: prevent console error when using datalist with text inputs #6594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethangardner merged 6 commits into from
Apr 22, 2026
Merged

fix: prevent console error when using datalist with text inputs #6594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
432b2aa
fix: prevent console error when using datalist with text inputs
vijaygovindaraja Mar 27, 2026
96affd0
Merge branch 'develop' into fix/6567-datalist-console-error
annepetersen Mar 30, 2026
b4e37b0
Merge branch 'develop' into fix/6567-datalist-console-error
annepetersen Apr 9, 2026
5b9fd30
Merge branch 'develop' into fix/6567-datalist-console-error
ethangardner Apr 21, 2026
e25d7ae
fix: add instanceof KeyboardEvent check to keymap guard
vijaygovindaraja Apr 21, 2026
00c8de4
Merge branch 'develop' into fix/6567-datalist-console-error
ethangardner Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/uswds-core/src/js/utils/keymap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,17 @@
* @param {KeymapConfig} map
* @return {KeyboardEventHandler}
*/
module.exports = (map) => (event) =>
module.exports = (map) => (event) => {
// Bail out if this is not a KeyboardEvent (e.g. InputEvent from datalist
// selection). Only KeyboardEvents have `key` and `getModifierState`.
if (
Comment thread
ethangardner marked this conversation as resolved.
!(event instanceof KeyboardEvent) ||
typeof event.key === "undefined" ||
typeof event.getModifierState !== "function"
) {
return;
}

Object.keys(map).forEach((combo) => {
// Each key combination can have one or more modifier, where each modifier is prefixed with the
// modifier name and "+".
Expand All @@ -39,3 +49,4 @@ module.exports = (map) => (event) =>
map[combo](event);
}
});
};
6 changes: 3 additions & 3 deletions packages/uswds-core/src/js/utils/validate-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ module.exports = function validate(el) {
`[data-validation-status]`,
);

const checked = validatorPattern.test(el.value);
validatorCheckbox.classList.toggle(CHECKED_CLASS, checked);

if (!validatorCheckbox) {
throw new Error(`No validator checkbox found for: "${validatorName}"`);
}

const checked = validatorPattern.test(el.value);
validatorCheckbox.classList.toggle(CHECKED_CLASS, checked);

// Create status reports for checklist items
const statusComplete = el.dataset.validationComplete || "status complete";
const statusIncomplete =
Expand Down
Loading