Visitar URL original
USWDS - Table: Restore row header border in borderless tables by manichandra · Pull Request #6661 · uswds/uswds · GitHub
Skip to content

USWDS - Table: Restore row header border in borderless tables - #6661

Merged
ethangardner merged 4 commits into
uswds:developfrom
manichandra:codex/uswds-6552-borderless-row-header
Aug 5, 2026
Merged

ethangardner merged 4 commits into
uswds:developfrom
manichandra:codex/uswds-6552-borderless-row-header

Conversation

@manichandra

Copy link
Copy Markdown
Contributor

Summary

Improved borderless table display for tables with row headers. Row-scoped body header cells now keep their top border so row headers do not appear visually disconnected.

Breaking change

This is not a breaking change.

Related issue

Closes #6552

Related pull requests

None.

Preview link

Preview link: N/A

Problem statement

Borderless tables remove the top border from all table header cells, including row-scoped header cells inside tbody. This can make row headers appear visually inconsistent or disconnected from the rest of the table row.

Solution

Restored the top border for tbody th[scope="row"] within the borderless table mixin, using the existing table border color token. This keeps row headers visually aligned while preserving the borderless table treatment elsewhere.

Major changes

  • Restored border-top for row-scoped body header cells in borderless tables.

Testing and review

  • npx prettier --check packages/uswds-core/src/styles/mixins/general/table.scss
  • npx stylelint packages/uswds-core/src/styles/mixins/general/table.scss
  • npx gulp compileSass
  • npm run lint:sass
  • git diff --check
  • Confirmed compiled CSS includes the restored selector.

@github-actions

Copy link
Copy Markdown
Contributor

✅ All commits on this PR have a verified signature. Thanks!

@manichandra

Copy link
Copy Markdown
Contributor Author

@jonathanbobel let me know any changes are needed.

@jonathanbobel jonathanbobel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ethangardner
ethangardner merged commit 651edcf into uswds:develop Aug 5, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Triage to Fed Final Review in USWDS Core Project Data Aug 5, 2026
@ethangardner ethangardner added this to the uswds 3.14.0 - Aug 2026 milestone Aug 5, 2026
@annepetersen annepetersen added the ❤️ Thanks Historical appreciation marker. Prefer a reaction; not required for triage. label Aug 5, 2026
@chandracarney chandracarney moved this from Fed Final Review to Done in USWDS Core Project Data Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

❤️ Thanks Historical appreciation marker. Prefer a reaction; not required for triage.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

USWDS - Bug: first row-scope TH missing top border in borderless tables

5 participants