Visitar URL original
USWDS - Footer: Prevent unsafe element creation from data-tag attribute by IHIutch · Pull Request #6674 · uswds/uswds · GitHub
Skip to content

USWDS - Footer: Prevent unsafe element creation from data-tag attribute #6674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethangardner merged 4 commits into from
Jun 19, 2026
Merged

USWDS - Footer: Prevent unsafe element creation from data-tag attribute #6674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08683d2
Set fixed "allowed tags" headings for footer big link list headings
IHIutch May 25, 2026
be9aae3
Add graceful fallback test
IHIutch May 25, 2026
26a367a
Prettier
IHIutch May 25, 2026
868e71a
Merge branch 'develop' into fix-footer-dom-text-reinterpretation
ethangardner Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/usa-footer/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,16 @@ function toggleHtmlTag(isMobile) {

const primaryLinks = bigFooter.querySelectorAll(BUTTON);

const ALLOWED_TAGS = ["h1", "h2", "h3", "h4", "h5", "h6"];

primaryLinks.forEach((currentElement) => {
const currentElementClasses = currentElement.getAttribute("class");
const preservedHtmlTag =
currentElement.getAttribute("data-tag") || currentElement.tagName;
const rawPreservedTag = (
currentElement.getAttribute("data-tag") || currentElement.tagName
).toLowerCase();
const preservedHtmlTag = ALLOWED_TAGS.includes(rawPreservedTag)
? rawPreservedTag
: "h4";

const newElementType = isMobile ? "button" : preservedHtmlTag;

Expand Down
14 changes: 14 additions & 0 deletions packages/usa-footer/src/test/footer.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,5 +132,19 @@ tests.forEach(({ name, selector: containerSelector }) => {
assert.strictEqual(buttons()[0].tagName, initialHtmlTag);
assert.strictEqual(buttons()[0].getAttribute("data-tag"), null);
});

it("falls back to h4 when data-tag is not in the allow-list", () => {
resizeTo(400);
assert.strictEqual(buttons()[0].tagName, "BUTTON");

buttons()[0].setAttribute("data-tag", "script");
buttons()[1].setAttribute("data-tag", "<img src=x onerror=alert(1)>");
buttons()[2].setAttribute("data-tag", "h7");

resizeTo(1024);
assert.strictEqual(buttons()[0].tagName, "H4");
assert.strictEqual(buttons()[1].tagName, "H4");
assert.strictEqual(buttons()[2].tagName, "H4");
});
});
});