Repository navigation
docs(Return to top) Use #top for "Return to top" component - #7005
caseywatts wants to merge 1 commit into
Conversation
|
✅ All commits on this PR have a verified signature. Thanks! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThree test templates change their return-to-top link target from ChangesTest template link updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Suggested labels: Merge Risk: ⚪ Minimal · up to The updated example links continue to take users to the page top in supported browsers. These template changes present no identified merge-blocking behavior risk. 🚥 Pre-merge checks | ✅ 8 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (8 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I don't consent to using CodeRabbit... sorry, I'll close this PR 😞 |
Summary
Updates the example template for the "Return to top" component to make it clearer that the anchor link works. Both
#and#topwork, but#topis a bit more explicit about the intention behind it.Problem statement
Some individuals implementing USWDS get confused, believing they need to manually add an anchor tag to the top of the page for this feature to work. We can be explicit about this in the documentation, and avoid having this question come up at all. This makes the code easier to understand, and more intention-revealing.
Solution
#top-- that's the main way people end up using these templates.#and#topboth work, and that both are widely supported by browsers:AI disclosure
What AI tools did you use to create this MR?
Testing and review
Test this feature in a multiple browsers (locally, or in a tool like SauceLabs if you have access to that):
#with#top(is there a way to preview that in this repo? A Storybook or something? I'm not sure)#topon the page.