Visitar URL original
USWDS-Sandbox: Zombie defense component updates by mahoneycm · Pull Request #106 · uswds/uswds-sandbox · GitHub
Skip to content

USWDS-Sandbox: Zombie defense component updates - #106

Closed
mahoneycm wants to merge 9 commits into
jb-zombie-defense-trainingfrom
cm-zombie-defense-updates
Closed

mahoneycm wants to merge 9 commits into
jb-zombie-defense-trainingfrom
cm-zombie-defense-updates

Conversation

@mahoneycm

@mahoneycm mahoneycm commented Aug 2, 2023 •

Copy link
Copy Markdown
Contributor

Summary

Implements changes documented in this component testing planning mural board.

This branch also updates to the latest uswds-sandbox repo

Note
To minimize changed files, we should pull the latest changes into the target branch

Related Issue

Resolves #99

Preview link

Zombie Defense Training →

Changes

  • Implements state combobox
    • In the miro page, this was originally proposed to be dependant on the in-person course option being selected
    • Dan mentioned not relying on a logic decision to display any form elements, but to have them all be readily available.
    • Instead, I just added the state combobox to the default form page
  • Implements file upload component
  • Implements step indicator component
  • Updates input mask pattern
    • New pattern: AAA-###
    • Old pattern: A#A-#A#
  • Installs latest uswds 3.6.0 package
    • Corrects input mask hover style issue

Exclusions

  • Combobox keyboard navigations were improved with USWDS - Combobox: Keyboard selection compliance update. Resolves #5161 uswds#5160 and included with the USWDS update.
  • Input mask improvements in #5227 are still in progress
  • Character Count hint text was not adjusted as discussed with @jaclinec
    • Dan mentioned not wanting to move the 25 characters allowed from below the text input
    • Adding a separate label would be redundant and cause screen readers to announce the character limit twice
    • Most screen readers will be able to provide the information to users, this is only a potential difficulty with screen magnifier users

@mahoneycm
mahoneycm requested a review from jaclinec August 2, 2023 19:33
@mahoneycm

mahoneycm commented Aug 10, 2023 •

Copy link
Copy Markdown
Contributor Author

Updates after discussion w/ @jaclinec

  • Input mask has disabled hover state
    • Current USWDS bug. Will be resolved with 3.6.0
  • Updated alphanumeric pattern to AAA-###
  • Looked into character count allowing input past limit
    • This is an expected pattern and how the component natively acts
  • Implemented step indicator

@mahoneycm mahoneycm linked an issue Aug 10, 2023 that may be closed by this pull request
Resolves input mask hover issue
@mahoneycm

Copy link
Copy Markdown
Contributor Author

Update 8.25

Installed latest USWDS package which resolved the input mask hover style issue

</h1>
</div>
</div>

@mejiaj mejiaj Oct 24, 2023 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future enhancement

Consider moving this to an include to make it easier to update.

@mahoneycm

Copy link
Copy Markdown
Contributor Author

Closing as this work is no longer needed

@mahoneycm mahoneycm closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zombie training prototype changes for August 2023 testing

2 participants