Visitar URL original
USWDS - Docs: Replace deprecated `$theme-site-max-width` variable. by mejiaj · Pull Request #1198 · uswds/uswds-site · GitHub
Skip to content

USWDS - Docs: Replace deprecated $theme-site-max-width variable. - #1198

Merged
thisisdano merged 6 commits into
mainfrom
je-docs-incorrect-grid-width-var
Apr 22, 2021
Merged

thisisdano merged 6 commits into
mainfrom
je-docs-incorrect-grid-width-var

Conversation

@mejiaj

@mejiaj mejiaj commented Mar 29, 2021 •

Copy link
Copy Markdown
Contributor

Description

Replaces previous PR #1176. This branch has latest from main and also removes references to the deprecated variable. Closes #1038.

Additional information

Pages affected:

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@thisisdano
thisisdano merged commit db370b4 into main Apr 22, 2021
@thisisdano
thisisdano deleted the je-docs-incorrect-grid-width-var branch April 22, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect grid width variable in docs ($theme-site-max-width vs $theme-grid-container-max-width)

2 participants