Visitar URL original
USWDS-Site - Date picker and date range picker: update props tables by amyleadem · Pull Request #1605 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site - Date picker and date range picker: update props tables - #1605

Merged
thisisdano merged 2 commits into
mainfrom
al-date-range-picker
Jun 17, 2022
Merged

thisisdano merged 2 commits into
mainfrom
al-date-range-picker

Conversation

@amyleadem

@amyleadem amyleadem commented May 17, 2022 •

Copy link
Copy Markdown
Contributor

Description

Part 1/2 to close uswds/uswds#4247.

Preview link: Date range picker page

Problem

Our documentation provided incorrect information about where to add data-min-date and data-max-date attributes to the date range picker component. Additionally, we do not have have stories to demonstrate how these properties work on date range picker.

Two-part solution

This PR is part 1 of a two-step solution to close uswds/uswds#4247.

Additional information

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@amyleadem
amyleadem marked this pull request as ready for review May 17, 2022 18:04
@amyleadem
amyleadem requested review from mahoneycm and mejiaj May 17, 2022 18:05
@mejiaj
mejiaj requested a review from thisisdano June 17, 2022 16:59
@mejiaj mejiaj assigned thisisdano and unassigned mejiaj Jun 17, 2022
@thisisdano
thisisdano merged commit a3a57c5 into main Jun 17, 2022
@thisisdano
thisisdano deleted the al-date-range-picker branch June 17, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date Range Picker min date and max date not disabling dates

3 participants