Visitar URL original
Docs: add $theme-footer-max-width variable by mejiaj · Pull Request #1719 · uswds/uswds-site · GitHub
Skip to content

Docs: add $theme-footer-max-width variable - #1719

Merged
thisisdano merged 1 commit into
mainfrom
jm-footer-docs
Aug 29, 2022
Merged

thisisdano merged 1 commit into
mainfrom
jm-footer-docs

Conversation

@mejiaj

@mejiaj mejiaj commented Jul 20, 2022 •

Copy link
Copy Markdown
Contributor

Description

This PR adds $theme-footer-max-width to the documentation. Closes #1696.

Additional information

Seen on pages


Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj
mejiaj marked this pull request as ready for review July 20, 2022 16:17
@mejiaj
mejiaj requested a review from amyleadem July 20, 2022 16:18

@amyleadem amyleadem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mejiaj
mejiaj requested a review from thisisdano July 26, 2022 18:25
@thisisdano
thisisdano merged commit 77c3857 into main Aug 29, 2022
@thisisdano
thisisdano deleted the jm-footer-docs branch August 29, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

USWDS-Site - Bug: Footer component missing '$theme-footer-max-width' setting documentation

3 participants