Visitar URL original
USWDS-Site: Vivid variable typos on Settings page by pglevy · Pull Request #1767 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site: Vivid variable typos on Settings page - #1767

Merged
mejiaj merged 2 commits into
uswds:mainfrom
pglevy:typos-settings-vivid-variables
Sep 16, 2022
Merged

USWDS-Site: Vivid variable typos on Settings page#1767
mejiaj merged 2 commits into
uswds:mainfrom
pglevy:typos-settings-vivid-variables

Conversation

@pglevy

@pglevy pglevy commented Sep 11, 2022

Copy link
Copy Markdown
Contributor

Description

The variables for primary-vivid and secondary-vivid are incorrect. (They repeat the variables for primary and secondary instead of using the associated vivid variable.)

Additional information

n/a

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

mejiaj
mejiaj approved these changes Sep 12, 2022
View reviewed changes

@mejiaj mejiaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this PR!!

@mejiaj
mejiaj requested a review from thisisdano September 15, 2022 19:57
@mejiaj

mejiaj commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

@pglevy are you able to pull in the latest changes from main branch? I think that might fix the snyk issues.

@pglevy

pglevy commented Sep 16, 2022

Copy link
Copy Markdown
Contributor Author

Hmm… I merged the changes from upstream/main, but the build test still seems to be failing with the same Snyk is missing auth token in order to run inside CI message. Anything else I can try on my end?

@mejiaj

mejiaj commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

Hmm… I merged the changes from upstream/main, but the build test still seems to be failing with the same Snyk is missing auth token in order to run inside CI message. Anything else I can try on my end?

Thank you, I'm pulling these changes into a local branch so the tests can run properly!

@mejiaj
mejiaj merged commit b03bf18 into uswds:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thisisdano thisisdano Awaiting requested review from thisisdano
1 more reviewer
@mejiaj mejiaj mejiaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pglevy @mejiaj