Visitar URL original
USWDS-Site - Form templates: Add guidance for labelling required fields by bonnieAcameron · Pull Request #1834 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site - Form templates: Add guidance for labelling required fields #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 25 commits into from
May 10, 2023
Merged

USWDS-Site - Form templates: Add guidance for labelling required fields #1834

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f0265ff
updated the forms page with Jacline's form usability best practices
bonnieAcameron Oct 14, 2022
c37d59d
Update _includes/accessibility.html
bonnieAcameron Oct 21, 2022
e199013
Update _includes/accessibility.html
bonnieAcameron Oct 21, 2022
29fac48
Update _includes/accessibility.html
bonnieAcameron Oct 21, 2022
66a8f82
Update _includes/accessibility.html
bonnieAcameron Oct 21, 2022
7fa05a5
Update _includes/accessibility.html
bonnieAcameron Oct 21, 2022
a0c72a4
Update _includes/accessibility.html
bonnieAcameron Oct 21, 2022
a1f0b60
remove "error handling"
bonnieAcameron Oct 21, 2022
18eaaf9
Update placement of screen reader note
bonnieAcameron Oct 21, 2022
80509b7
update file name to reflect new content
bonnieAcameron Oct 21, 2022
72eaf07
Remove bolded note
bonnieAcameron Oct 21, 2022
420fdfd
Merge branch 'main' of https://github.com/uswds/uswds-site into bc-up…
Oct 21, 2022
c0555bc
Update accessibility.html references
Oct 21, 2022
859e349
Merge branch 'main' of https://github.com/uswds/uswds-site into bc-up…
Oct 31, 2022
5924271
Apply copyedits from code review
thisisdano Mar 7, 2023
fbdb3d9
Merge branch 'main' of https://github.com/uswds/uswds-site into bc-up…
Mar 24, 2023
b7fa18f
Add changelog
Mar 24, 2023
7fe4a2e
Fix typos
Mar 24, 2023
7c867d6
Remove text-decoration from abbr[title='required']
Mar 24, 2023
8043f40
Merge branch 'main' of https://github.com/uswds/uswds-site into bc-up…
Mar 27, 2023
f86a250
Format
Mar 29, 2023
3974a51
Change required fields section title; change styling on note
Mar 30, 2023
3032a79
Pull template-form changelog data into component-form; set both form …
Mar 31, 2023
0c2c662
Add note to changelog about use on multiple pages
Apr 6, 2023
22b6fce
Fix typo
Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add note to changelog about use on multiple pages
  • Loading branch information
Amy Leadem
Amy Leadem committed Apr 6, 2023
commit 0c2c662223208a3759c81aba18764c62fe6ba48e
44 changes: 4 additions & 40 deletions _data/changelogs/component-form.yml
View file
Open in desktop

@mejiaj mejiaj Apr 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to have a comment at the top that says what pages this data appears on.

@amyleadem amyleadem Apr 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. Added a commented note in 0c2c662

Original file line number Diff line number Diff line change
@@ -1,23 +1,13 @@
# Note: This changelog is used on multiple pages:
# templates/form-templates
# components/form
title: Form
type: component
changelogURL:
items:
- date: 2023-04-03
summary: Added documentation for required links.
summaryAdditional:
isBreaking:
affectsAccessibility:
affectsAssets:
affectsGuidance: true
affectsJavascript:
affectsMarkup:
affectsStyles:
githubPr: 1834
githubRepo: uswds-site
versionUswds:
- date: 2023-03-13
summary: Fixed invisible link text for links styled as buttons within forms.
summaryAdditional: Now link text does not match the primary button color when nested inside of a form and the `usa-button` class is present.
summaryAdditional: Now link text does not match the primary button color when nested inside of a form and the `usa-button` class is presenZkt.
isBreaking: false
affectsStyles: true
githubPr: 5112
Expand All @@ -32,29 +22,3 @@ items:
githubPr: 4656
githubRepo: uswds
versionUswds: 3.0.0
- date: 2021-12-28
summary: Updated support notes for `aria-describedby`.
summaryAdditional:
isBreaking:
affectsAccessibility:
affectsAssets:
affectsGuidance: true
affectsJavascript:
affectsMarkup:
affectsStyles:
githubPr: 1363
githubRepo: uswds-site
versionUswds:
- date: 2021-03-17
summary: Moved form templates to templates section.
summaryAdditional:
isBreaking:
affectsAccessibility:
affectsAssets:
affectsGuidance: true
affectsJavascript:
affectsMarkup:
affectsStyles:
githubPr: 1136
githubRepo: uswds-site
versionUswds: