Visitar URL original
USWDS-Site: Header - Add changelog entry for megamenu fix. by mejiaj · Pull Request #2111 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site: Header - Add changelog entry for megamenu fix. - #2111

Merged
thisisdano merged 10 commits into
dw-changelog-button-outline-whcfrom
jm-extended-megamenu-bug-5305
Jun 8, 2023
Merged

USWDS-Site: Header - Add changelog entry for megamenu fix.#2111
thisisdano merged 10 commits into
dw-changelog-button-outline-whcfrom
jm-extended-megamenu-bug-5305

Conversation

@mejiaj

@mejiaj mejiaj commented May 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Added changelog entry for header megamenu code example fix.

Related PR

Related to fix in uswds/uswds#5311.

Preview link

Preview link:

Solution

Updates changelog & Header with megamenu examples.

Warning
This build will fail because of this file input disabled variant being deleted in USWDS/USWDS. More info in this comment.

This PR uses feature branch to confirm code example markup is now fixed.

@mejiaj mejiaj mentioned this pull request May 30, 2023
Merged
amyleadem
amyleadem suggested changes May 31, 2023
View reviewed changes

@amyleadem amyleadem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mejiaj I added a couple suggestions for clarity. Let me know if you have any questions.

Comment thread package.json Outdated
"dependencies": {
"@uswds/compile": "^1.0.0-beta.3",
"@uswds/uswds": "^3.4.1"
"@uswds/uswds": "github:uswds/uswds#jm-extended-megamenu-bug-5305"

@amyleadem amyleadem May 31, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making a visible comment as a reminder to revert this branch update :)

@mejiaj mejiaj Jun 2, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. This is clearer than the PR description note, though both might be useful. Thanks!

Comment thread _data/changelogs/component-header.yml Resolved
Comment thread _data/changelogs/component-header.yml Resolved
Comment thread _data/changelogs/component-header.yml Resolved
Comment thread _data/changelogs/component-header.yml Outdated
type: component
changelogURL:
items:
- date: TK

@amyleadem amyleadem May 31, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the 3.5.0 changelog PR uses this date format. I think it would be good if we made it standard practice moving forward to reduce possible errors in the future.

Suggested change
- date: TK
- date: NNNN-NN-NN

@mejiaj mejiaj Jun 2, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I've made the change in 04b9616. I've also updated changelog README in baba58f. Feel free to make any additional changes.

@amyleadem amyleadem mentioned this pull request Jun 2, 2023
Merged
23 of 24 tasks
@amyleadem amyleadem changed the title USWDS - Header: Add changelog entry for megamenu fix. USWDS-Site: Header - Add changelog entry for megamenu fix. Jun 2, 2023
@amyleadem amyleadem added this to the uswds 3.5.0 milestone Jun 2, 2023
James Mejia and others added 5 commits June 2, 2023 16:00
James Mejia @amyleadem
Update _data/changelogs/component-header.yml
37adce5 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
James Mejia @amyleadem
Update _data/changelogs/component-header.yml
69bc480 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
James Mejia
Add flag to header changelog
f914a9e
James Mejia
Update placeholder date
04b9616
James Mejia
Update changelog README
baba58f 
- Adjust table spacing
- Add placeholder text for dates
@mejiaj
mejiaj requested a review from amyleadem June 2, 2023 21:13
@amyleadem
amyleadem changed the base branch from main to dw-changelog-button-outline-whc June 2, 2023 22:08
@thisisdano
thisisdano marked this pull request as ready for review June 6, 2023 22:55
@thisisdano
thisisdano merged commit b3ca247 into dw-changelog-button-outline-whc Jun 8, 2023
@thisisdano
thisisdano deleted the jm-extended-megamenu-bug-5305 branch June 8, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@thisisdano thisisdano thisisdano approved these changes
@amyleadem amyleadem amyleadem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

uswds 3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mejiaj @thisisdano @amyleadem