Visitar URL original
USWDS-Site - Disabled color contrast changelog by mahoneycm · Pull Request #2254 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site - Disabled color contrast changelog - #2254

Merged
amyleadem merged 8 commits into
release-3.8.0from
cm-disabled-color-contrast-changelog
Mar 1, 2024
Merged

amyleadem merged 8 commits into
release-3.8.0from
cm-disabled-color-contrast-changelog

Conversation

@mahoneycm

@mahoneycm mahoneycm commented Aug 21, 2023 •

Copy link
Copy Markdown
Contributor

Summary

Changelog entry for uswds/uswds#5455

Added color contrast checks for disabled tokens. On compilation, USWDS will test disabled element color contrast and provide a fallback color if minimum contrast is not met. If the fallback does not meet minimum requirements, a warning will be provided.

Preview link

Settings changelog →
Form changelog →

@amyleadem
amyleadem changed the base branch from main to release-3.8.0 February 20, 2024 20:00
Comment thread _data/changelogs/docs-settings.yml Resolved
Comment thread _data/changelogs/docs-settings.yml Resolved
mahoneycm and others added 2 commits February 28, 2024 13:36
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm
mahoneycm requested a review from amyleadem February 28, 2024 18:36
@mahoneycm

Copy link
Copy Markdown
Contributor Author

@amyleadem committed your suggestions! Thanks for the input!

@amyleadem

Copy link
Copy Markdown
Contributor

Looking at this again and I wonder if this should be moved either to the form page or to the individual component pages instead of the settings page.

Previously, we have added disabled color update changelogs to the individual component pages, for example checkbox. I lean towards doing the same here.

@mahoneycm

Copy link
Copy Markdown
Contributor Author

Looking at this again and I wonder if this should be moved either to the form page or to the individual component pages instead of the settings page.

Previously, we have added disabled color update changelogs to the individual component pages, for example checkbox. I lean towards doing the same here.

Ooh good point. I definitely agree it should be added to the form page. It was originally added to the settings page because the error would happen if users update the theme color settings, so I feel like we should also maintain it here.

I was on the fence about adding it for every component with disabled styles because it wasn't necessarily component-specific, but ultimately I think it's better to have it than not. I'll work on getting these added!

@mahoneycm

Copy link
Copy Markdown
Contributor Author

Update 2/29/24

After some more discussion with the team, we decided to keep the changelog on the settings and form pages but not each component page because it is specifically a settings change

Noting that other disabled style changes may still need to be included in component pages moving forward.

Comment thread _data/changelogs/docs-settings.yml Resolved
@amyleadem
amyleadem merged commit 78cf901 into release-3.8.0 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants