Visitar URL original
USWDS-Site - Changelog: Add entry for indeterminate checkboxes by mahoneycm · Pull Request #2482 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site - Changelog: Add entry for indeterminate checkboxes - #2482

Merged
thisisdano merged 6 commits into
mainfrom
cm-changelog-5713
Apr 26, 2024
Merged

thisisdano merged 6 commits into
mainfrom
cm-changelog-5713

Conversation

@mahoneycm

@mahoneycm mahoneycm commented Feb 9, 2024 •

Copy link
Copy Markdown
Contributor

Summary

Adds changelog entry for uswds/uswds#5713

Added indeterminate styles for checkboxes. Checkboxes will now display as indeterminate when input.indeterminate = true is set via JS or the data-indeterminate attribute is present. This is currently only a style addition and does not affect checkbox functionality.

Preview link

Checkbox changelog →

Comment thread _data/changelogs/component-checkbox.yml Resolved
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm
mahoneycm requested a review from amyleadem February 21, 2024 15:12
Comment thread _data/changelogs/component-checkbox.yml Resolved
@mejiaj mejiaj changed the title USWDS-Site - Changelog: Add entry for indeterminate checkboxes [#5713] USWDS-Site - Changelog: Add entry for indeterminate checkboxes Mar 5, 2024
@mahoneycm
mahoneycm requested a review from amyleadem March 5, 2024 18:34
@mahoneycm
mahoneycm changed the base branch from release-3.8.0 to main March 22, 2024 16:04

@amyleadem amyleadem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mahoneycm
mahoneycm requested a review from thisisdano March 25, 2024 13:57
@mahoneycm

Copy link
Copy Markdown
Contributor Author

@thisisdano Looks like this got left out in the 3.8.0 changelogs. Updated with the latest and ready for final review! 👍

Comment thread _data/changelogs/component-checkbox.yml Outdated
type: component
changelogURL:
items:
- date: 2024-03-11

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

We should update the changelog date before merge

Comment thread _data/changelogs/component-checkbox.yml Resolved
@thisisdano
thisisdano merged commit 148db21 into main Apr 26, 2024
@thisisdano
thisisdano deleted the cm-changelog-5713 branch April 26, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants