Visitar URL original
USWDS-Site - Changelog: Add entry for reordering content in Documentation example by mejiaj · Pull Request #2495 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site - Changelog: Add entry for reordering content in Documentation example - #2495

Merged
thisisdano merged 7 commits into
release-3.8.0from
jm-changelog-doc-template
Mar 11, 2024
Merged

USWDS-Site - Changelog: Add entry for reordering content in Documentation example#2495
thisisdano merged 7 commits into
release-3.8.0from
jm-changelog-doc-template

Conversation

@mejiaj

@mejiaj mejiaj commented Feb 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Added changelog entry for Documentation page template update.

Related issue

Part of #2477. Related to uswds/uswds#5794 and uswds/uswds#5809.

Preview link

Preview link →

Changelog should appear in sidenav & bottom of the page.

This was referenced Feb 20, 2024
Closed
Closed
@amyleadem
amyleadem changed the base branch from main to release-3.8.0 February 20, 2024 19:14
amyleadem
amyleadem reviewed Feb 20, 2024
View reviewed changes
Comment thread _data/changelogs/template-documentation.yml Resolved
@mejiaj
mejiaj marked this pull request as ready for review February 20, 2024 19:34
@mejiaj
mejiaj requested a review from amyleadem February 20, 2024 19:34
@thisisdano

thisisdano commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

I'm adding a Hold label to this PR while we work through uswds/uswds#5681

My comments on the related PR: uswds/uswds#5681 (comment)

@amyleadem amyleadem mentioned this pull request Feb 29, 2024
Merged
@mahoneycm mahoneycm mentioned this pull request Mar 1, 2024
Merged
5 tasks
@mahoneycm

mahoneycm commented Mar 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Update 3/1/24

Updated to reflect alternate solution uswds/uswds#5794

amyleadem
amyleadem reviewed Mar 4, 2024
View reviewed changes
Comment thread _data/changelogs/template-documentation.yml Resolved
amyleadem
amyleadem reviewed Mar 4, 2024
View reviewed changes
Comment thread _data/changelogs/template-documentation.yml Resolved
amyleadem
amyleadem reviewed Mar 4, 2024
View reviewed changes
Comment thread _data/changelogs/template-documentation.yml Resolved
@mejiaj

mejiaj commented Mar 6, 2024

Copy link
Copy Markdown
Contributor Author

Removing hold; there's a new solution in uswds/uswds#5794.

mahoneycm @amyleadem
Apply suggestions from code review
161d84c 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm
mahoneycm requested a review from amyleadem March 6, 2024 15:16
amyleadem
amyleadem reviewed Mar 6, 2024
View reviewed changes

@amyleadem amyleadem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @mahoneycm.
I had one question about considering this a breaking change. Let me know what you think!

Comment thread _data/changelogs/template-documentation.yml Resolved
mahoneycm @amyleadem
Update _data/changelogs/template-documentation.yml
b26cbf2 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
amyleadem
amyleadem approved these changes Mar 6, 2024
View reviewed changes

@amyleadem amyleadem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mejiaj mejiaj mentioned this pull request Mar 8, 2024
Merged
7 tasks
@thisisdano
thisisdano merged commit de14f27 into release-3.8.0 Mar 11, 2024
@thisisdano
thisisdano deleted the jm-changelog-doc-template branch March 11, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@mahoneycm mahoneycm mahoneycm left review comments
@thisisdano thisisdano thisisdano approved these changes
@amyleadem amyleadem amyleadem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mejiaj @thisisdano @mahoneycm @amyleadem