Visitar URL original
USWDS-Site: Add select accessibility tests page by amyleadem · Pull Request #2702 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site: Add select accessibility tests page - #2702

Merged
thisisdano merged 22 commits into
mainfrom
al-a11y-tests-select
Jun 19, 2024
Merged

USWDS-Site: Add select accessibility tests page#2702
thisisdano merged 22 commits into
mainfrom
al-a11y-tests-select

Conversation

@amyleadem

@amyleadem amyleadem commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

Summary

Added accessibility tests page for the select component.

Important

We should update changelog dates before merge.

Related issue

Closes #2666

Preview link

Resources

Testing and review

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm no visual issues.
  8. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@amyleadem amyleadem changed the title Add select accessibility page USWDS-Site: Add select accessibility tests page Jun 4, 2024
@amyleadem
amyleadem marked this pull request as ready for review June 4, 2024 22:14
amyleadem
amyleadem commented Jun 4, 2024
View reviewed changes

@amyleadem amyleadem left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for review. Please review the questions in the comments below. Let me know if you have any questions.

Comment thread _data/accessibility-tests/select.yml Resolved
Comment thread _data/accessibility-tests/select.yml Resolved
Comment thread _data/accessibility-tests/select.yml Outdated
Comment on lines +75 to +76
When you are using a screen reader,
you will know the common purpose of the select option (eg., date, time, state).

@amyleadem amyleadem Jun 4, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-hull @amycole501 @sarah-sch @finekatie
Wondering if we can provide a more specific example for clarity

Suggested change
When you are using a screen reader,
you will know the common purpose of the select option (eg., date, time, state).
When you are using a screen reader,
you will hear the common purpose of the select option (eg., "Select your state").

@amycole501 amycole501 Jun 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that revision especially since select elements are often used for a variety of common lists. I think state, day, time are all good options.

@amyleadem amyleadem Jun 6, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to "eg., "Select your state"" in ef4aa40

Comment thread _data/accessibility-tests/select.yml Resolved
Comment thread _data/accessibility-tests/select.yml Resolved
Comment thread _data/accessibility-tests/select.yml Resolved
@sarah-sch
sarah-sch removed the request for review from finekatie June 6, 2024 17:39
@sarah-sch
Update select.yml
224096a 
adding missing period
sarah-sch
sarah-sch reviewed Jun 6, 2024
View reviewed changes

@sarah-sch sarah-sch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed a change to add a missing period. Have a question for a11y team about whether we're referencing the correct WCAG criterion on the test "Content doesn’t change until the user takes an action to change it."

Comment thread _data/accessibility-tests/select.yml Resolved
@amyleadem amyleadem mentioned this pull request Jun 11, 2024
Closed
5 tasks done
@amyleadem
amyleadem requested a review from sarah-sch June 11, 2024 19:16
@finekatie
finekatie removed the request for review from sarah-sch June 13, 2024 15:55
@amyleadem

amyleadem commented Jun 13, 2024

Copy link
Copy Markdown
Contributor Author

@amycole501 @alex-hull @sarah-sch @finekatie @mahoneycm

I believe I have addressed all your comments. This is ready for your re-review.

@amyleadem
amyleadem requested a review from sarah-sch June 13, 2024 18:40
@amyleadem
amyleadem requested a review from finekatie June 13, 2024 19:06
mahoneycm
mahoneycm suggested changes Jun 13, 2024
View reviewed changes

@mahoneycm mahoneycm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small changes for consistency with recent test pages.

Potentially non-blocker as these are changing over time. We discussed doing an audit in the future to catch inconsistencies but it'd be nice to get ahead of it

Comment thread _data/accessibility-tests/select.yml Resolved
Comment thread _data/accessibility-tests/select.yml Resolved
Comment thread _data/accessibility-tests/select.yml Resolved
@finekatie
finekatie removed the request for review from sarah-sch June 14, 2024 17:03
finekatie
finekatie approved these changes Jun 14, 2024
View reviewed changes

@finekatie finekatie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything has been resolved that I was asked to look at, so I give the all clear!

@amyleadem
amyleadem requested a review from thisisdano June 14, 2024 20:38
thisisdano
thisisdano reviewed Jun 19, 2024
View reviewed changes

@thisisdano thisisdano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog publish dates

Comment thread _data/changelogs/component-select-accessibility.yml Resolved
Comment thread _data/changelogs/component-select.yml Resolved
@thisisdano
thisisdano merged commit 5b652b1 into main Jun 19, 2024
@thisisdano
thisisdano deleted the al-a11y-tests-select branch June 19, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-hull alex-hull Awaiting requested review from alex-hull
5 more reviewers
@thisisdano thisisdano thisisdano left review comments
@sarah-sch sarah-sch sarah-sch left review comments
@mahoneycm mahoneycm mahoneycm approved these changes
@amycole501 amycole501 amycole501 approved these changes
@finekatie finekatie finekatie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CC a11y: publish Select checklist - create PR

7 participants

@amyleadem @thisisdano @mahoneycm @sarah-sch @amycole501 @alex-hull @finekatie