Visitar URL original
USWDS-Site: Added combo box accessibility tests page by CTGM-Bixal · Pull Request #2811 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site: Added combo box accessibility tests page - #2811

Merged
thisisdano merged 7 commits into
mainfrom
rc-publish-combobox-checklist
Sep 18, 2024
Merged

USWDS-Site: Added combo box accessibility tests page#2811
thisisdano merged 7 commits into
mainfrom
rc-publish-combobox-checklist

Conversation

@CTGM-Bixal

@CTGM-Bixal CTGM-Bixal commented Sep 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Added accessibility test page for combo box component

Related issue

Closes #2768

Preview link

Preview link:
Combo Box Component Page

Testing and review

Follow these steps:

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm no visual issues.
  8. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@CTGM-Bixal
CTGM-Bixal marked this pull request as ready for review September 6, 2024 21:12
CTGM-Bixal
CTGM-Bixal commented Sep 6, 2024
View reviewed changes

@CTGM-Bixal CTGM-Bixal left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amycole501 and @mahoneycm - There are a few things I wasn't sure about for this checklist and made comments on them in the "Files Changed" tab. Let me know if they are correct or any guidance on what to update would be great!

amyleadem
amyleadem suggested changes Sep 6, 2024
View reviewed changes

@amyleadem amyleadem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here @RachelCorsino! Everything looks good here. Just had a couple of questions for @amycole501 and @alex-hull.

Comment thread _data/accessibility-tests/combo-box.yml Outdated
Comment thread _data/accessibility-tests/combo-box.yml Outdated
@amyleadem amyleadem mentioned this pull request Sep 11, 2024
Open
amyleadem
amyleadem reviewed Sep 16, 2024
View reviewed changes
Comment thread _data/accessibility-tests/combo-box.yml Outdated
@amyleadem
amyleadem requested a review from finekatie September 16, 2024 17:02
@finekatie @amyleadem
Update summary for 4.1.2
7e1b62d 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
finekatie
finekatie approved these changes Sep 16, 2024
View reviewed changes

@finekatie finekatie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

mahoneycm
mahoneycm approved these changes Sep 16, 2024
View reviewed changes

@mahoneycm mahoneycm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @RachelCorsino 👍

amyleadem
amyleadem approved these changes Sep 16, 2024
View reviewed changes

@amyleadem amyleadem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @RachelCorsino!

@amycole501 or @alex-hull, could you review and confirm that everything appears as expected?

alex-hull
alex-hull approved these changes Sep 16, 2024
View reviewed changes

@alex-hull alex-hull left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good! Approved on my end!

amyleadem
amyleadem reviewed Sep 18, 2024
View reviewed changes
Comment thread _data/changelogs/component-combo-box-accessibility.yml Outdated
title: Combo box accessibility tests
type: component
items:
- date: NNNN-NN-NN

@amyleadem amyleadem Sep 18, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

We need to update the changelog dates before merge

thisisdano
thisisdano reviewed Sep 18, 2024
View reviewed changes
Comment thread _data/changelogs/component-combo-box-accessibility.yml Outdated
thisisdano
thisisdano reviewed Sep 18, 2024
View reviewed changes
Comment thread _data/changelogs/component-combo-box.yml Outdated
@thisisdano
thisisdano merged commit 6294f7f into main Sep 18, 2024
@thisisdano
thisisdano deleted the rc-publish-combobox-checklist branch September 18, 2024 20:46
@amyleadem amyleadem mentioned this pull request Jan 24, 2025
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cathybaptista cathybaptista Awaiting requested review from cathybaptista
6 more reviewers
@amyleadem amyleadem amyleadem approved these changes
@thisisdano thisisdano thisisdano approved these changes
@mahoneycm mahoneycm mahoneycm approved these changes
@amycole501 amycole501 amycole501 approved these changes
@alex-hull alex-hull alex-hull approved these changes
@finekatie finekatie finekatie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CC a11y: publish combo box checklist - create PR

7 participants

@CTGM-Bixal @thisisdano @mahoneycm @amyleadem @amycole501 @alex-hull @finekatie