Visitar URL original
USWDS-Site: Add changelog for modal PREFIX constants [#6026] by cathybaptista · Pull Request #2842 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site: Add changelog for modal PREFIX constants [#6026] - #2842

Merged
amyleadem merged 17 commits into
release-3.10.0from
cb-changelog-6026
Nov 6, 2024
Merged

amyleadem merged 17 commits into
release-3.10.0from
cb-changelog-6026

Conversation

@cathybaptista

@cathybaptista cathybaptista commented Sep 25, 2024 •

Copy link
Copy Markdown
Contributor

Summary

This PR provides a changelog entry for changes to the Modal component JavaScript. Because the component takes advantage of constants, users can bundle the modal package with a custom prefix.

Related issue

[USWDS - Modal: Use classname constants for all variable references in JS file]

Preview link

USWDS-Site: Modal

Testing and review

  1. Ensure changelog entry shows up under "Latest Updates" on Modal component page.

@cathybaptista
cathybaptista marked this pull request as ready for review September 25, 2024 22:57
James Mejia and others added 5 commits October 21, 2024 11:40
Add focus trap guidance.
Add changelog entry to Modal focus trap guidance.
Replacing this:

Test print outputs. Test printing using a variety of printers, print-to-PDF options, and assistive output devices, using representative browser and operating system combinations prior to launch. Remember that mobile device users will have additional challenges printing or saving to PDF so some on-screen guidance may be necessary.

with this:
Test print outputs. Test printing using a variety of printers, print-to-PDF options, and assistive output devices, using representative browser and operating system combinations based on your site's visitor data prior to launch. Remember that mobile device users will have additional challenges printing or saving to PDF so some on-screen guidance may be necessary.
Will need updated date when ready to publish
Comment thread _data/changelogs/component-modal.yml Resolved
@amyleadem
amyleadem changed the base branch from main to release-3.10.0 November 5, 2024 23:32
@amyleadem
amyleadem merged commit 5979879 into release-3.10.0 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants