Visitar URL original
USWDS-Site: Added pagination accessibility test page by CTGM-Bixal · Pull Request #2865 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site: Added pagination accessibility test page - #2865

Merged
thisisdano merged 7 commits into
mainfrom
rc-pagination-checklist
Oct 16, 2024
Merged

USWDS-Site: Added pagination accessibility test page#2865
thisisdano merged 7 commits into
mainfrom
rc-pagination-checklist

Conversation

@CTGM-Bixal

@CTGM-Bixal CTGM-Bixal commented Oct 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Added accessibility test page for pagination component

Related issue

Closes #2858

Preview link

Preview link: Pagination Component Page

Testing and review

Follow these steps:

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm no visual issues.
  8. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@CTGM-Bixal
CTGM-Bixal marked this pull request as ready for review October 9, 2024 18:43
mejiaj
mejiaj approved these changes Oct 10, 2024
View reviewed changes

@mejiaj mejiaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RachelCorsino, looks good.

I've added some formatting fixes and notes to update the placeholder date before we merge.

Comment thread _data/changelogs/component-pagination-accessibility.yml Outdated
title: Pagination accessibility tests
type: component
items:
- date: NNNN-NN-NN

@mejiaj mejiaj Oct 10, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: Need to add date.

Comment thread _data/changelogs/component-pagination.yml Outdated
githubPr: 4175
githubRepo: uswds
versionUswds: 2.12.0
- date: NNNN-NN-NN

@mejiaj mejiaj Oct 10, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: Need to add date.

Suggested change
- date: NNNN-NN-NN
- date: NNNN-NN-NN

mahoneycm
mahoneycm suggested changes Oct 15, 2024
View reviewed changes

@mahoneycm mahoneycm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Found an incorrect criterion number to be updated and asked a question of our a11y team

Testing checklist

  • Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  • Confirm that the main component page links to the accessibility tests page in the side navigation.
  • Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  • Confirm that the main component page shows the accessibility tests summary.
  • Check that accessibility tests page provides the correct counts for each test status type.
  • Confirm the test checklist summaries and data are accurate.
    • “Screen reader announces role values” should be criterion 4.1.2 Name, role, value
    • Should 2.4.8 be conditional as well?
  • Confirm no visual issues.
  • Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

Comment thread _data/accessibility-tests/pagination.yml Resolved
Comment thread _data/accessibility-tests/pagination.yml Resolved
@CTGM-Bixal
CTGM-Bixal requested a review from mahoneycm October 16, 2024 19:19
mahoneycm
mahoneycm approved these changes Oct 16, 2024
View reviewed changes

@mahoneycm mahoneycm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @RachelCorsino !

@mejiaj
mejiaj requested a review from alex-hull October 16, 2024 19:49
alex-hull
alex-hull approved these changes Oct 16, 2024
View reviewed changes

@alex-hull alex-hull left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks look good!

thisisdano
thisisdano reviewed Oct 16, 2024
View reviewed changes
Comment thread _data/changelogs/component-pagination-accessibility.yml Resolved
thisisdano
thisisdano reviewed Oct 16, 2024
View reviewed changes
Comment thread _data/changelogs/component-pagination.yml Resolved
@thisisdano
thisisdano merged commit c54608e into main Oct 16, 2024
@thisisdano
thisisdano deleted the rc-pagination-checklist branch October 16, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cathybaptista cathybaptista Awaiting requested review from cathybaptista
4 more reviewers
@mejiaj mejiaj mejiaj approved these changes
@thisisdano thisisdano thisisdano approved these changes
@mahoneycm mahoneycm mahoneycm approved these changes
@alex-hull alex-hull alex-hull approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CC a11y: publish pagination checklist - create PR

5 participants

@CTGM-Bixal @mejiaj @thisisdano @mahoneycm @alex-hull