Visitar URL original
USWDS-Site: HTML-proofer fixes by amyleadem · Pull Request #3031 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site: HTML-proofer fixes - #3031

Merged
annepetersen merged 3 commits into
mainfrom
al-html-proofer-dec-2
Dec 18, 2024
Merged

USWDS-Site: HTML-proofer fixes#3031
annepetersen merged 3 commits into
mainfrom
al-html-proofer-dec-2

Conversation

@amyleadem

@amyleadem amyleadem commented Dec 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Removed the 404 link to VA Caseflow from the showcase page.

Related issue

N/A

Preview link

Showcase page

Problem statement

HTML-proofer flagged the following failure:

For the Links > External check, the following failures were found:

* At ./_site/documentation/showcase/index.html:2820:

  External link https://github.com/department-of-veterans-affairs/caseflow failed (status code 404)

Solution

Removed the VA Caseflow link from the showcase page because no suitable replacement could be found.

Note

The link in the wayback machine shows the repo seemed to be in active development recently, showing a release last week. Not sure if this indicates that the repo might only be temporarily down.

Testing and review

  • Confirm no suitable replacement exists for the removed link
  • Confirm changelog is present, accurate, and free from error

@amyleadem
amyleadem marked this pull request as ready for review December 18, 2024 17:00
@amyleadem
amyleadem requested a review from a team as a code owner December 18, 2024 17:00
mejiaj
mejiaj previously approved these changes Dec 18, 2024
View reviewed changes
Comment thread _data/changelogs/docs-showcase.yml Resolved
@amyleadem James Mejia
Update changelog date
90e84ba 
Co-authored-by: James Mejia <james.mejia@gsa.gov>
annepetersen
annepetersen approved these changes Dec 18, 2024
View reviewed changes

@annepetersen annepetersen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annepetersen
annepetersen merged commit 92baefd into main Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahoneycm mahoneycm Awaiting requested review from mahoneycm
@mandylloyd mandylloyd Awaiting requested review from mandylloyd
@CTGM-Bixal CTGM-Bixal Awaiting requested review from CTGM-Bixal
@cathybaptista cathybaptista Awaiting requested review from cathybaptista
@thisisdano thisisdano Awaiting requested review from thisisdano
2 more reviewers
@annepetersen annepetersen annepetersen approved these changes
@mejiaj mejiaj mejiaj left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amyleadem @mejiaj @annepetersen