Visitar URL original
USWDS-Site: Step Indicator Accessibility Checklist by CTGM-Bixal · Pull Request #3098 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site: Step Indicator Accessibility Checklist - #3098

Merged
thisisdano merged 9 commits into
mainfrom
rc-step-indicator-checklist
Feb 14, 2025
Merged

USWDS-Site: Step Indicator Accessibility Checklist#3098
thisisdano merged 9 commits into
mainfrom
rc-step-indicator-checklist

Conversation

@CTGM-Bixal

@CTGM-Bixal CTGM-Bixal commented Feb 7, 2025 •
edited by amyleadem
Loading

Copy link
Copy Markdown
Contributor

Summary

Added accessibility test page for step indicator component

Important

We need to update changelog dates before merge

Related issue

Closes #2668

Preview link

Step Indicator Component Page
Step Indicator Accessibility Tests Page

Testing and review

Follow these steps:

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm no visual issues.
  8. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

amyleadem
amyleadem suggested changes Feb 10, 2025
View reviewed changes

@amyleadem amyleadem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work @RachelCorsino! I found a couple small items to fix, outlined in the comments below.

I performed the following tests:

  • Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  • Confirm that the main component page links to the accessibility tests page in the side navigation.
    • Note: sidenav isn't working as expected
  • Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  • Confirm the main component page has the correct component name in the accessibility note
  • Confirm that the main component page shows the accessibility tests summary.
  • Confirm the accessibility tests page has the correct component name in the lead.
    • Note: The lead still uses the placeholder name.
  • Check that accessibility tests page provides the correct counts for each test status type.
  • Confirm the test checklist summaries and data are accurate.
    • Note: 1.4.10 should be reclassified as a "zoom" test
  • Confirm no visual issues.
  • Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

Comment thread _data/accessibility-tests/step-indicator.yml Resolved
Comment thread _components/step-indicator/step-indicator.md Resolved
Comment thread _components/step-indicator/accessibility-tests.md Resolved
@CTGM-Bixal
CTGM-Bixal requested a review from amyleadem February 10, 2025 21:54
amyleadem
amyleadem previously approved these changes Feb 10, 2025
View reviewed changes

@amyleadem amyleadem left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Passing to @finekatie and @alex-hull for review.

alex-hull
alex-hull previously approved these changes Feb 11, 2025
View reviewed changes

@alex-hull alex-hull left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

finekatie
finekatie reviewed Feb 11, 2025
View reviewed changes
Comment thread _data/accessibility-tests/step-indicator.yml Resolved
finekatie
finekatie reviewed Feb 11, 2025
View reviewed changes

@finekatie finekatie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one recommendation for a copy tweak. Otherwise, looks good.

@amyleadem
amyleadem dismissed stale reviews from alex-hull and themself via 8bdb09e February 13, 2025 00:12
@amyleadem

amyleadem commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

@finekatie Made the requested updates. This is ready for your re-review.

@amyleadem
amyleadem requested a review from finekatie February 13, 2025 00:13
finekatie
finekatie previously approved these changes Feb 13, 2025
View reviewed changes

@finekatie finekatie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. approved!

mahoneycm
mahoneycm suggested changes Feb 13, 2025
View reviewed changes

@mahoneycm mahoneycm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for your consideration! Let me know if you disagree

Comment thread _data/accessibility-tests/step-indicator.yml Resolved
@amyleadem Charlie Mahoney
Change 2.4.6 status to conditional
3bb48b2 
Co-authored-by: Charlie Mahoney <charlie.mahoney@bixal.com>
alex-hull
alex-hull previously approved these changes Feb 13, 2025
View reviewed changes
@amyleadem
amyleadem requested a review from amycole501 February 13, 2025 18:49
@amyleadem

amyleadem commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

@amycole501 Moving this to FFR. This is ready for your review.

@mahoneycm
mahoneycm self-requested a review February 13, 2025 19:22
mahoneycm
mahoneycm previously approved these changes Feb 13, 2025
View reviewed changes

@mahoneycm mahoneycm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

amycole501
amycole501 previously approved these changes Feb 13, 2025
View reviewed changes

@amycole501 amycole501 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

annepetersen
annepetersen approved these changes Feb 14, 2025
View reviewed changes

@annepetersen annepetersen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added changelog. otherwise LGTM

@amyleadem

amyleadem commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

@annepetersen I added my approval so it should be possible to merge this now.

@thisisdano
thisisdano merged commit 021837e into main Feb 14, 2025
@thisisdano
thisisdano deleted the rc-step-indicator-checklist branch February 14, 2025 17:32
@dependabot dependabot Bot mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandylloyd mandylloyd Awaiting requested review from mandylloyd
@cathybaptista cathybaptista Awaiting requested review from cathybaptista
6 more reviewers
@annepetersen annepetersen annepetersen approved these changes
@amyleadem amyleadem amyleadem approved these changes
@mahoneycm mahoneycm mahoneycm left review comments
@amycole501 amycole501 amycole501 left review comments
@alex-hull alex-hull alex-hull left review comments
@finekatie finekatie finekatie left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

USWDS-Site: Publish step indicator accessibility checklist page

8 participants

@CTGM-Bixal @amyleadem @annepetersen @mahoneycm @amycole501 @alex-hull @finekatie @thisisdano