Visitar URL original
USWDS-Site - Time Picker: Add combo box to time picker dependencies by IHIutch · Pull Request #3200 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site - Time Picker: Add combo box to time picker dependencies - #3200

Merged
ethangardner merged 2 commits into
uswds:mainfrom
IHIutch:update-time-picker-deps
Aug 28, 2026
Merged

USWDS-Site - Time Picker: Add combo box to time picker dependencies#3200
ethangardner merged 2 commits into
uswds:mainfrom
IHIutch:update-time-picker-deps

Conversation

@IHIutch

@IHIutch IHIutch commented May 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds usa-combo-box to time picker dependencies

Related issue

uswds/uswds#6560

Related PR

uswds/uswds#6634

Testing and review

Package usage: @forward 'usa-time-picker';Dependencies: uswds-fonts, usa-label, usa-hint, usa-input, usa-combo-box
  • Create a changelog entry for any user-facing changes. Learn more about creating changelogs in _data/changelogs/_CHANGELOG-README.md.
  • Confirm that this code follows the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run git pull origin [base branch] to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch is main).
  • Run npm run prettier:scss to format any Sass updates.
  • Run npm test and confirm that all tests pass.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.

@IHIutch IHIutch mentioned this pull request May 6, 2026
Merged
5 tasks done
@msbtterswrth

msbtterswrth commented May 21, 2026

Copy link
Copy Markdown

@IHIutch you've got some failing tests here too, i think both of these (#6634) are related and need to go together, if so should we combine them into one PR?

@IHIutch

IHIutch commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hm, the failing jobs don't seem related to my changes. One looks like a Snyk config issue and it seems like the pa11y issue is related to timing out scanning the page. Might be a flaky test.. The icon page is enormous, so it might be taking too long to scan

This PR and uswds/uswds#6634 are in different repos, so they can't be the same PR

@msbtterswrth

msbtterswrth commented May 21, 2026

Copy link
Copy Markdown

Ope I sure missed that this one is for the docs site. When Anne gets back next week we can poke them about the flaky tests.

@msbtterswrth
msbtterswrth self-requested a review June 23, 2026 19:18
msbtterswrth
msbtterswrth approved these changes Jun 23, 2026
View reviewed changes

@msbtterswrth msbtterswrth left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, JB!

ethangardner
ethangardner approved these changes Aug 28, 2026
View reviewed changes

@ethangardner ethangardner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this is a dependency of the time picker. Thanks for the contribituion. Approved!

@ethangardner
ethangardner merged commit 8e9e364 into uswds:main Aug 28, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Triage to Fed final review in USWDS Core Project Data Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@ethangardner ethangardner ethangardner approved these changes
@msbtterswrth msbtterswrth msbtterswrth approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

No open projects
USWDS Core Project Data
Status: Fed final review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IHIutch @msbtterswrth @ethangardner