Repository navigation
Conversation
date -f on lines like "Sat Sep 20 22:11:30 2014" was spending its time in the general date parser. Recognize that form directly. Other inputs still use the general parser, and the result matches it.
kprobe0
force-pushed
the
date-fast-english-datetime
branch
from
October 30, 2026 18:40
4dca890 to
3b4d49d
Compare
Collaborator
|
@kprobe0 please confirm it is ready for review or convert to draft |
Contributor
|
any idea why codspeed doesn't detect it ? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
date -fon ordinary lines such asSat Sep 20 22:11:30 2014was about 2.4× slower than GNU date. Fixes perf(date): Slower than GNU #14750 for that input.parse_datetime.Test plan
cargo test -p uu_date --lib english_datetimedate -fon the date list from perf(date): Slower than GNU #14750 matches GNU output and is closer to its runtime