Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 6, 2026 04:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isLocale('X-WHATEVER'),isLocale('de-CH-X-phonebk'), andisLocale('I-AMI')currently return false, although their lowercase equivalents pass. The assembled regex uses case-flexible character classes for most subtags but matches the literal private-use prefix and grandfathered tags case-sensitively.Compile the language-tag regex with the case-insensitive flag. Add regression coverage for mixed-case private-use prefixes, grandfathered tags, and malformed controls. This preserves the existing accepted syntax and underscore compatibility.
RFC 5646 §2.1.1 requires case-insensitive treatment of language tags and explicitly gives
I-AMIas equivalent toi-ami: https://www.rfc-editor.org/rfc/rfc5646.html#section-2.1.1Validation: the regression fails against the original source.
npm testpasses all builds, lint and 324 tests with 100% statement/function/line coverage; branch coverage remains 96.59%. Generated Node/browser/minified-browser checks also pass. Node 24.19.0 on Linux; the CI version matrix has not been run locally.Prepared with OpenAI Codex assistance.
Checklist