Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 8, 2026 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isLatLong(str, { checkDMS: true })accepts longitudes such as181° 0′ 0″ Eand799° 0′ 0″ W. The general degree pattern[1-7]?\d{1,2}also accepts 180, bypassing the dedicated branch that requires zero minutes and seconds.Restrict the general longitude branch to 0–179 degrees and use the boundary branch for 180 degrees. Preserve fractional zero seconds at the boundary. The regression fixtures cover both hemispheres, fractional seconds, and the transitions around 99, 100, 179, and 180 degrees.
Reference: NOAA's longitude overview.
Validation on Node.js 24.19.0:
npm test: 323 passing.npm test: 324 passing, including all builds, ESLint, and coverage.git diff --checkpassed.Prepared with Codex.
Checklist