Repository navigation
Conversation
Problem: :pythonx heredoc lines are parsed as Ex commands when skipping.
Solution: Consume the heredoc lines like the other :python commands, and
don't initialise 'pyxversion', when skipping. (Doug Kearns)
Signed-off-by: Doug Kearns <dougkearns@gmail.com>
Signed-off-by: Doug Kearns <dougkearns@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
See commit message.
Commit message
AI assistance
Checklist
Signed-off-by:trailer is presentAnything reviewers should know
I'm aware of at least a dozen command skipping issues that I turned up when working on something a little while ago, and more have been introduced recently. I'll endeavour to tease them out over the next few days.
@chrisbra, I think the robustness of command skipping should have been better tested before :source-dryrun was merged. I'd consider backing it out but if that's going to cause too much of a kerfuffle it would be a good idea to add a warning in the help until it is more mature.