Visitar URL original
:pythonx heredoc lines are parsed as Ex commands when skipping by dkearns · Pull Request #21422 · vim/vim · GitHub
Skip to content

:pythonx heredoc lines are parsed as Ex commands when skipping - #21422

Draft
dkearns wants to merge 2 commits into
vim:masterfrom
dkearns:fix-skipping-pythonx-commands
Draft

dkearns wants to merge 2 commits into
vim:masterfrom
dkearns:fix-skipping-pythonx-commands

Conversation

@dkearns

@dkearns dkearns commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

What does this change do?

See commit message.

Commit message

Problem:  :pythonx heredoc lines are parsed as Ex commands when skipping.
Solution: Consume the heredoc lines like the other :python commands, and
          don't initialise 'pyxversion', when skipping. (Doug Kearns)

AI assistance

  • No AI was used

Checklist

  • The commit message follows the Problem/Solution form above
  • Signed-off-by: trailer is present
  • Tests were added
  • No documentation update is needed

Anything reviewers should know

I'm aware of at least a dozen command skipping issues that I turned up when working on something a little while ago, and more have been introduced recently. I'll endeavour to tease them out over the next few days.

@chrisbra, I think the robustness of command skipping should have been better tested before :source-dryrun was merged. I'd consider backing it out but if that's going to cause too much of a kerfuffle it would be a good idea to add a warning in the help until it is more mature.

Problem:  :pythonx heredoc lines are parsed as Ex commands when skipping.
Solution: Consume the heredoc lines like the other :python commands, and
          don't initialise 'pyxversion', when skipping. (Doug Kearns)

Signed-off-by: Doug Kearns <dougkearns@gmail.com>
Signed-off-by: Doug Kearns <dougkearns@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant