Repository navigation
Conversation
h-east
force-pushed
the
pum-info-hidden-flicker
branch
from
October 3, 2026 04:05
c0acd89 to
18f107c
Compare
h-east
changed the title
Contributor
Author
|
The Linux ASAN failure in Test_termdebug_tbreak is not related to this |
Problem: The completion menu flickers when selecting an item creates the
info popup, and on every selection when there is no room for
the info popup.
Solution: Do not clear to the end of a screen line with T_CE when the
popup menu covers part of it. Do not handle creating the info
popup as splitting a window.
Selecting an item redraws the text under the menu. screen_fill() skips
the cells under the menu, but the T_CE shortcut clears them and the
menu is drawn again. T_CE is not used while a popup window is visible,
so this only happened when the info popup was hidden for lack of room.
prepare_tagpreview() returned TRUE when it created the info popup, and
pum_set_selected() took that as a resized window: the text under the
menu was drawn over it. Creating a popup does not change the window
layout.
Assisted-by: Claude
Signed-off-by: Hirohito Higashi <h.east.727@gmail.com>
h-east
force-pushed
the
pum-info-hidden-flicker
branch
from
October 5, 2026 13:37
18f107c to
0830944
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting an item redraws the text under the menu. screen_fill() skips
the cells under the menu, but the T_CE shortcut clears them and the
menu is drawn again. T_CE is not used while a popup window is visible,
so this only happened when the info popup was hidden for lack of room.
prepare_tagpreview() returned TRUE when it created the info popup, and
pum_set_selected() took that as a resized window: the text under the
menu was drawn over it. Creating a popup does not change the window
layout.
AI assistance
Checklist
Signed-off-by:trailer is present (git commit -s)