Visitar URL original
chore: fix type errors and run type check in CI by ValentinYoushkevich · Pull Request #3142 · vuejs/eslint-plugin-vue · GitHub
Skip to content

chore: fix type errors and run type check in CI - #3142

Merged
ota-meshi merged 2 commits into
vuejs:masterfrom
ValentinYoushkevich:chore/typecheck-ci
Oct 7, 2026
Merged

chore: fix type errors and run type check in CI#3142
ota-meshi merged 2 commits into
vuejs:masterfrom
ValentinYoushkevich:chore/typecheck-ci

Conversation

@ValentinYoushkevich

@ValentinYoushkevich ValentinYoushkevich commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

npm run tsc currently fails on master with five errors, which went unnoticed because CI never runs it. This fixes them and adds a type check step to the build job, right after npm run build, since some tests import from dist.

One error is mine from #3113, a missing ComponentProp type import in no-unused-properties. The other four come from prefer-separate-static-class: isStringLiteral is a type guard, so after it returns false TypeScript assumes the node can't be a TemplateLiteral at all. Checking for a template literal with expressions first fixes the narrowing without changing behavior.

@changeset-bot

changeset-bot Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 62018a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

FloEdelmann
FloEdelmann approved these changes Sep 24, 2026
View reviewed changes

@FloEdelmann FloEdelmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ota-meshi
ota-meshi requested changes Oct 7, 2026
View reviewed changes

@ota-meshi ota-meshi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
Could you also revise the documentation?

https://eslint.vuejs.org/developer-guide/#jsdoc-type-checking-with-typescript

@ValentinYoushkevich

ValentinYoushkevich commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Sure, good point. I'll update that section of the developer guide and push it here shortly.

ota-meshi
ota-meshi approved these changes Oct 7, 2026
View reviewed changes

@ota-meshi ota-meshi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for modifying the document! LGTM!

@ota-meshi
ota-meshi merged commit 67637f6 into vuejs:master Oct 7, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes
@ota-meshi ota-meshi ota-meshi approved these changes
@waynzh waynzh Awaiting requested review from waynzh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ValentinYoushkevich @FloEdelmann @ota-meshi