Visitar URL original
refactor: migrate script `no-deprecated-*` rules to TypeScript by ValentinYoushkevich · Pull Request #3173 · vuejs/eslint-plugin-vue · GitHub
Skip to content

refactor: migrate script no-deprecated-* rules to TypeScript - #3173

Merged
FloEdelmann merged 1 commit into
vuejs:masterfrom
ValentinYoushkevich:refactor/ts-no-deprecated-script-rules
Oct 17, 2026
Merged

refactor: migrate script no-deprecated-* rules to TypeScript#3173
FloEdelmann merged 1 commit into
vuejs:masterfrom
ValentinYoushkevich:refactor/ts-no-deprecated-script-rules

Conversation

@ValentinYoushkevich

@ValentinYoushkevich ValentinYoushkevich commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Next batch after #3169: the eight script-side no-deprecated-* rules, namely data-object-declaration, destroyed-lifecycle, dollar-listeners-api, dollar-scopedslots-api, events-api, model-definition, props-default-this and vue-config-keycodes. They fit together well: all are small, follow the same executeOnVue/defineVueVisitor shape, depend only on utils and have no dependents. I left no-deprecated-delete-set out since #3055 already covers it.

The changes are mechanical: ESM imports and exports, JSDoc types and the ScopeStack typedef turned into TypeScript annotations, the lib/plugin.ts imports and the "Rule source" links updated. Rule behavior is unchanged, so there is no changeset. All 89 tests of these rules pass, tsc is clean, and npm run update produces no diff.

Part of #2777

@changeset-bot

changeset-bot Bot commented Oct 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 645634c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ValentinYoushkevich ValentinYoushkevich mentioned this pull request Oct 17, 2026
Merged
FloEdelmann
FloEdelmann approved these changes Oct 17, 2026
View reviewed changes

@FloEdelmann FloEdelmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FloEdelmann FloEdelmann added the meta Code style improvements, build process improvements, refactorings label Oct 17, 2026
@FloEdelmann
FloEdelmann merged commit e698f5c into vuejs:master Oct 17, 2026
17 checks passed
@FloEdelmann FloEdelmann mentioned this pull request Oct 17, 2026
Open
@FloEdelmann

FloEdelmann commented Oct 17, 2026

Copy link
Copy Markdown
Member

I left no-deprecated-delete-set out since #3055 already covers it.

Next time, you don't need to constrain your scope to not touch files that are part of #3007 or #3055. Those PRs already have many merge conflicts, so if a file can be migrated to TypeScript in a smaller batch already, that only makes conflict resolution easier (just accept the changes on master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees

No one assigned

Labels

meta Code style improvements, build process improvements, refactorings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ValentinYoushkevich @FloEdelmann