Visitar URL original
Update IDL and enumerated attribute section by jnurthen · Pull Request #1611 · w3c/aria · GitHub
Skip to content

Update IDL and enumerated attribute section - #1611

Merged
jnurthen merged 5 commits into
mainfrom
issue1598
Sep 17, 2021
Merged

Update IDL and enumerated attribute section#1611
jnurthen merged 5 commits into
mainfrom
issue1598

Conversation

@jnurthen

@jnurthen jnurthen commented Sep 3, 2021 •
edited by cookiecrook
Loading

Copy link
Copy Markdown
Member

fixes #1598

Preview | Diff

@jnurthen

jnurthen commented Sep 7, 2021

Copy link
Copy Markdown
Member Author

fixes #1598

cyns
cyns approved these changes Sep 8, 2021
View reviewed changes

@cyns cyns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cyns cyns mentioned this pull request Sep 9, 2021
Closed
cookiecrook
cookiecrook approved these changes Sep 9, 2021
View reviewed changes

@cookiecrook cookiecrook left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Removed the whitespace-only diff b/c it seemed accidental.

Comment thread index.html Resolved
Comment thread index.html Resolved
scottaohara
scottaohara reviewed Sep 9, 2021
View reviewed changes
Comment thread index.html Resolved
scottaohara
scottaohara reviewed Sep 9, 2021
View reviewed changes
Comment thread index.html Resolved
jnurthen and others added 3 commits September 9, 2021 11:01
@jnurthen @cookiecrook
Update index.html
d61f6fe 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@jnurthen @cookiecrook
Update index.html
fccd6e6 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@jnurthen
fix review comment (closing </p>)
2acf5cd
scottaohara
scottaohara reviewed Sep 13, 2021
View reviewed changes
Comment thread index.html Resolved
jongund
jongund approved these changes Sep 15, 2021
View reviewed changes

@jongund jongund left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jnurthen
jnurthen merged commit 0d06a71 into main Sep 17, 2021
@jnurthen jnurthen mentioned this pull request Sep 17, 2021
Closed
jnurthen added a commit that referenced this pull request Sep 17, 2021
@jnurthen @cyns @cookiecrook
Update IDL and enumerated attribute section (#1611)
cd04b6a 
Co-authored-by: Cynthia Shelly <cyns@users.noreply.github.com>
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@jnurthen jnurthen mentioned this pull request Sep 23, 2021
Closed
@liamdebeasi liamdebeasi mentioned this pull request Oct 27, 2021
Closed
4 of 6 tasks
@joanmarie

joanmarie commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

crap. clicked on the wrong thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyns cyns cyns approved these changes
@scottaohara scottaohara scottaohara left review comments
@cookiecrook cookiecrook cookiecrook approved these changes
@jongund jongund jongund approved these changes
+1 more reviewer
@marcoscaceres marcoscaceres marcoscaceres left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Updating ARIA 1.2 due to IDL implementations (exit and re-enter CR?)

7 participants

@jnurthen @joanmarie @cookiecrook @marcoscaceres @jongund @cyns @scottaohara